-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe a possible ISSUE, and an additional security consideration. #1
Conversation
Some typos fixed.
(192.168.0.1) via te browser? Although evil-printer could directly attack | ||
innocent-router (e.g. port scan and then SSH password, brute-force), the | ||
availability of credentials in the UA might give evil-printer more power than | ||
it already has, and the UA should deny it by default. No? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current algorithm, that would depend upon the state of the Document or Worker which initiated the request. That is, if https://public.example.com/
loads the printer's script via <script src="https://printer.local/script.js">
and that script initiates a request to https://whatever.local/
, the request would be CORSified.
If, on the other hand, the user navigates to https://printer.local/
directly (or that page allows itself to be framed or loaded as a worker), then the request to https://whatever.local/
would work the way it does today by requiring a preflight for unsafe requests, and not requiring a preflight for "safe" requests.
It's not clear that we could change the behavior of intranets in general to require CORS when talking to other intranet servers. That seems like a bit much to ask for.
Thanks! Happy to pull this in as-is, but it's probably worth talking a bit about the issue first. The question isn't clear to me, nor is what you'd like the answer to be. :) |
I'd suggest pulling it as-is, so we can all mull it over. Basically, perhaps we shouldn't think of it is as "a private service should opt in to being contacted by the public", but rather, "a private service should opt into being contacted by anyone other than itself and the 1st party UA". I am not sure what the answer is, but I do lean toward changing the proposal so that private services must always opt in to being contacted by anyone other than themselves and the 1st party UA. |
Describe a possible ISSUE, and an additional security consideration.
Ok. Merged. I'll poke at the issue text a bit to clarify what I think you're getting at. Thanks! |
The current version of the document still includes an open question (marked "Issue 2") about whether "private to private" requests should always be opt-in, with a link here. I see that this PR hasn't had activity in 5 years, but I don't see any other open issues about it, so I'd like to contribute a thought, and it can be moved to a separate issue if need be. I think there is more cost than benefit here. Yes, you should be concerned about requests from If you're going to think about requiring opt-in, it would have to be on a long time horizon, like the rollout of |
That's fair, thanks for chiming in! I agree that breaking public websites is easier than breaking IoT devices and the like, for the very reasons you give. I'm keeping this issue here in our back pocket because I'd be interested in tackling it later. It is a strict add-on to the current proposal, so there should be no wasted work if we first break public -> private and then concern ourselves with private -> private. |
I've filed issue #39 to continue the discussion on this topic. This PR is not the best forum. |
Some typos fixed.