Rename to Private Network Access. #106

letitz · 2023-05-25T15:57:40Z

annevk · 2023-05-25T16:03:30Z

I don't think we should do this.

letitz · 2023-05-25T17:05:15Z

As stated in #91, I consider the current state of affairs (spec name = local, header = private) to be an unfortunate accident. I think it would be marginally better to align terms between spec and implementation, in order to minimize developer confusion.

In this light, is this something you could live with, and we could standardize in Fetch?

annevk · 2023-05-25T17:36:33Z

I think I've also stated what I prefer in #91. 😊

letitz · 2023-05-26T09:51:22Z

Right! So far, however, only preferences have been expressed by all parties. I'm looking to answer a more specific question here: do you think keeping with the old name would block standardization?

Unless you believe we could not standardize PNA under that name and with that terminology in HTML/Fetch, I think it best to minimize confusion by reverting back to the name that was used for a couple years and align with header names.

annevk · 2023-05-26T09:53:53Z

I don't know.

annevk · 2023-05-26T09:56:48Z

To elaborate, Fetch at least tends to use the correct terminology, even if that's not the terminology we end up exposing through APIs. You can see this with various timing APIs, for instance. The same is true elsewhere in the web platform, e.g., with URLs. It would be weird to break tradition with that.

letitz · 2023-05-26T14:35:20Z

Understood. Given the lack of formal standards positions from other browsers, we'll go ahead and rename this spec back to be consistent with its API. In the meantime, would you mind responding on the WebKit standards position (WebKit/standards-positions#163) with how WebKit feels about the possibility of upstreaming this specification to Fetch? I believe we would need such a statement when upstreaming into Fetch anyway. At that point, we can revisit terminology while merging.

letitz · 2023-06-07T14:32:56Z

@johnathan79717 I believe this is ready for review. Can you PTAL?

johnathan79717

LGTM

letitz · 2023-06-07T14:43:00Z

Thanks!

SHA: ac2c8aa Reason: push, by letitz Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This reverts commit 09f21d8c48ebc54193b12874c895648c69dfbe92. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in WPTs > > In WICG/private-network-access#91, we decided to > rename Private Network Access to Local Network Access. The spec has > already been renamed in > WICG/private-network-access#97. The latest spec: > https://wicg.github.io/local-network-access/ > > This CL renames PrivateNetwork to LocalNetwork in wpt file names. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033 > Commit-Queue: Jonathan Hao <phao@chromium.org> > Reviewed-by: Weizhong Xia <weizhong@google.com> > Cr-Commit-Position: refs/heads/main@{#1115802} Bug: 1418287 Change-Id: I8f29e58c4a0e8741be98bc9fd640510e1473e61c

…ion_metrics.md" This reverts commit 7893736. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in web_mitigation_metrics.md > > In WICG/private-network-access#91, we decided to > rename Private Network Access to Local Network Access. The spec has > already been renamed in > WICG/private-network-access#97. The latest spec: > https://wicg.github.io/local-network-access/ > > This CL renames PrivateNetwork to LocalNetwork in > web_mitigation_metrics.md. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: If5d23739cba049908731f5fa97aff9f79a4037cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334390 > Reviewed-by: Titouan Rigoudy <titouan@chromium.org> > Commit-Queue: Jonathan Hao <phao@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1118030} Bug: 1418287 Change-Id: Icc21a4fc48a12e85038c017a1f0821a6660f0f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670561 Commit-Queue: Jonathan Hao <phao@chromium.org> Reviewed-by: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1168121}

…oup_browsertest.cc" This reverts commit c6a9a9a. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in interest_group_browsertest.cc > > In WICG/private-network-access#91, we decided to > rename Private Network Access to Local Network Access. The spec has > already been renamed in > WICG/private-network-access#97. The latest spec: > https://wicg.github.io/local-network-access/ > > This CL renames PrivateNetwork to LocalNetwork in > interest_group_browsertest.cc. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > > Change-Id: If1f8bbc9c5e8d87c8761dcf33ba41abd60114da0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336326 > Reviewed-by: Caleb Raitto <caraitto@chromium.org> > Auto-Submit: Jonathan Hao <phao@chromium.org> > Commit-Queue: Jonathan Hao <phao@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1117589} Bug: 1418287 Change-Id: I476f0f99ee9d6192ad6ffa7080a70c240a1e9ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4669624 Reviewed-by: Caleb Raitto <caraitto@chromium.org> Commit-Queue: Jonathan Hao <phao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1168148}

…owsertest.cc" This reverts commit cdd0a01. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in web_view_browsertest.cc > > In WICG/private-network-access#91, we decided to > rename Private Network Access to Local Network Access. The spec has > already been renamed in > WICG/private-network-access#97. The latest spec: > https://wicg.github.io/local-network-access/ > > This CL renames PrivateNetwork to LocalNetwork in > web_view_browsertest.cc. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > > Change-Id: I52fa91a66f225f7076cc1f1d4a9068c0ea880d82 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335665 > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Auto-Submit: Jonathan Hao <phao@chromium.org> > Reviewed-by: Bo Liu <boliu@chromium.org> > Commit-Queue: Bo Liu <boliu@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1117536} Bug: 1418287 Change-Id: I4658cb3f7ee33e7ab89c0a290dc551db79022828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4671591 Reviewed-by: Bo Liu <boliu@chromium.org> Auto-Submit: Jonathan Hao <phao@chromium.org> Quick-Run: Jonathan Hao <phao@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Commit-Queue: Jonathan Hao <phao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1168202}

… local" This reverts commit 262019a. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename content setting from private to local > > In WICG/private-network-access#91, we decided to > rename (public, private, local) IP address spaces to (public, local, > loopback) and rename the spec to Local Network Access. The spec has > already been renamed in > WICG/private-network-access#97. > New spec: > https://wicg.github.io/local-network-access/#ip-address-space-heading > > This CL renames the occurrences in content settings. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: I5f1e6bfc5fcda6598e761eb201274ea9409609f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335304 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Jonathan Hao <phao@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1117088} Bug: 1418287 Change-Id: I3a3afd97546650506410d57b81831ee63404dc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670562 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Jonathan Hao <phao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1168233}

This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in request.cc > > In WICG/private-network-access#91, we decided to > rename (public, private, local) IP address spaces to (public, local, > loopback). The spec has already been renamed in > WICG/private-network-access#97. > New spec: > https://wicg.github.io/local-network-access/#ip-address-space-heading > > This CL renames the string representation in request.cc. It also updates > a mixed content wpt because it uses targetAddressSpace defined in > Request. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Commit-Queue: Jonathan Hao <phao@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1115707} Bug: 1418287 Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac

This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in request.cc > > In WICG/private-network-access#91, we decided to > rename (public, private, local) IP address spaces to (public, local, > loopback). The spec has already been renamed in > WICG/private-network-access#97. > New spec: > https://wicg.github.io/local-network-access/#ip-address-space-heading > > This CL renames the string representation in request.cc. It also updates > a mixed content wpt because it uses targetAddressSpace defined in > Request. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Commit-Queue: Jonathan Hao <phao@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1115707} Bug: 1418287 Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564 Reviewed-by: Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Auto-Submit: Jonathan Hao <phao@chromium.org> Quick-Run: Jonathan Hao <phao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1168815}

The spec has been renamed back to Private Network Access. WICG/private-network-access#106 Also add "tentative" to file names since PNA is not shipped yet. Bug: 1418287 Change-Id: I8285c2c3ff7b6df032d40949005f7231ccd8430b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4684226 Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: Jonathan Hao <phao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1170027}

This reverts commit eccd2c1. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename chrome browsertest. > > Bug: chromium:1418287 > Change-Id: I128095f446ca9b56a6fafc7a90eb54d009241eca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4324684 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Titouan Rigoudy <titouan@chromium.org> > Auto-Submit: Titouan Rigoudy <titouan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1115759} Bug: chromium:1418287 Change-Id: Ic1d692f2e00bcc39c171336a96f61238e4c7dd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4693905 Reviewed-by: Titouan Rigoudy <titouan@chromium.org> Commit-Queue: Jonathan Hao <phao@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/main@{#1172271}

…k_access/." This reverts commit de91ac2. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename chrome/test/data/private_network_access/. > > Bug: chromium:1418287 > Change-Id: I7310eec1bb8e1ca6a22c6788e4f15cb6bb67324a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329275 > Auto-Submit: Titouan Rigoudy <titouan@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1116358} Bug: chromium:1418287 Change-Id: I2f90dddbbd710d9ac71c681c9032559141c47fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4694343 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Jonathan Hao <phao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1172312}

…ivate to local in request.cc", a=testonly Automatic update from web-platform-tests Revert "[Local Network Access] Rename private to local in request.cc" This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in request.cc > > In WICG/private-network-access#91, we decided to > rename (public, private, local) IP address spaces to (public, local, > loopback). The spec has already been renamed in > WICG/private-network-access#97. > New spec: > https://wicg.github.io/local-network-access/#ip-address-space-heading > > This CL renames the string representation in request.cc. It also updates > a mixed content wpt because it uses targetAddressSpace defined in > Request. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Commit-Queue: Jonathan Hao <phao@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1115707} Bug: 1418287 Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564 Reviewed-by: Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Auto-Submit: Jonathan Hao <phao@chromium.org> Quick-Run: Jonathan Hao <phao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1168815} -- wpt-commits: 0b9e87dcaa97a472760b165f20679338ddcbf30b wpt-pr: 40968

…ivate to local in request.cc", a=testonly Automatic update from web-platform-tests Revert "[Local Network Access] Rename private to local in request.cc" This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in request.cc > > In WICG/private-network-access#91, we decided to > rename (public, private, local) IP address spaces to (public, local, > loopback). The spec has already been renamed in > WICG/private-network-access#97. > New spec: > https://wicg.github.io/local-network-access/#ip-address-space-heading > > This CL renames the string representation in request.cc. It also updates > a mixed content wpt because it uses targetAddressSpace defined in > Request. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043 > Reviewed-by: Camille Lamy <clamychromium.org> > Commit-Queue: Jonathan Hao <phaochromium.org> > Cr-Commit-Position: refs/heads/main{#1115707} Bug: 1418287 Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564 Reviewed-by: Arthur Hemery <ahemerychromium.org> Commit-Queue: Arthur Hemery <ahemerychromium.org> Auto-Submit: Jonathan Hao <phaochromium.org> Quick-Run: Jonathan Hao <phaochromium.org> Cr-Commit-Position: refs/heads/main{#1168815} -- wpt-commits: 0b9e87dcaa97a472760b165f20679338ddcbf30b wpt-pr: 40968 UltraBlame original commit: 3363e3ba006e3d6813284cdf2adfcade6c21df88

…Ts", a=testonly Automatic update from web-platform-tests Revert "Rename Private Network Access WPTs" The spec has been renamed back to Private Network Access. WICG/private-network-access#106 Also add "tentative" to file names since PNA is not shipped yet. Bug: 1418287 Change-Id: I8285c2c3ff7b6df032d40949005f7231ccd8430b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4684226 Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: Jonathan Hao <phao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1170027} -- wpt-commits: 1b4e731fff74f4cb1571b475de86d506c648b2e5 wpt-pr: 41022

…Ts", a=testonly Automatic update from web-platform-tests Revert "Rename Private Network Access WPTs" The spec has been renamed back to Private Network Access. WICG/private-network-access#106 Also add "tentative" to file names since PNA is not shipped yet. Bug: 1418287 Change-Id: I8285c2c3ff7b6df032d40949005f7231ccd8430b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4684226 Reviewed-by: Weizhong Xia <weizhonggoogle.com> Commit-Queue: Jonathan Hao <phaochromium.org> Cr-Commit-Position: refs/heads/main{#1170027} -- wpt-commits: 1b4e731fff74f4cb1571b475de86d506c648b2e5 wpt-pr: 41022 UltraBlame original commit: 3bbcd36a71dbe8637e0d2c70502736e4baeec0b5

…Ts", a=testonly Automatic update from web-platform-tests Revert "Rename Private Network Access WPTs" The spec has been renamed back to Private Network Access. WICG/private-network-access#106 Also add "tentative" to file names since PNA is not shipped yet. Bug: 1418287 Change-Id: I8285c2c3ff7b6df032d40949005f7231ccd8430b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4684226 Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: Jonathan Hao <phao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1170027} -- wpt-commits: 1b4e731fff74f4cb1571b475de86d506c648b2e5 wpt-pr: 41022

…il.*." This reverts commit 503a326. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename c/p/t/private_network_access_util.*. > > Bug: chromium:1418287 > Change-Id: Ie975e11476894b2e900448d2f60d2a2a5b6b3e82 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4324839 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Commit-Queue: Titouan Rigoudy <titouan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1115698} Bug: chromium:1418287 Change-Id: I386ec7df9cec8075b2533cc049e718f718b5171a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4694108 Reviewed-by: Titouan Rigoudy <titouan@chromium.org> Commit-Queue: Jonathan Hao <phao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1176088}

…il.*." This reverts commit e619b48. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename c/b/r/private_network_access_util.*. > > The contents of the file will be renamed later, to keep reviews simpler. > > Bug: chromium:1418287 > Change-Id: I3d95f81bbfde7ca3fadf02da2657cddeb3bf2218 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4324677 > Auto-Submit: Titouan Rigoudy <titouan@chromium.org> > Commit-Queue: Camille Lamy <clamy@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1115686} Bug: chromium:1418287 Change-Id: Ib1aed1e748ee3da21db6940bf9c9bdd4eea47dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4694977 Auto-Submit: Jonathan Hao <phao@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Titouan Rigoudy <titouan@chromium.org> Commit-Queue: Jonathan Hao <phao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1176099}

The spec has been renamed back to Private Network Access. WICG/private-network-access#106 Bug: 1418287 Change-Id: I5ac7664bb885f560725327e20c0f59a1c0a3ccff

The spec has been renamed back to Private Network Access. WICG/private-network-access#106 Bug: 1418287 Change-Id: I5ac7664bb885f560725327e20c0f59a1c0a3ccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5002120 Auto-Submit: Jonathan Hao <phao@chromium.org> Reviewed-by: Yifan Luo <lyf@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1220560}

The spec has been renamed back to Private Network Access. WICG/private-network-access#106 Bug: 1418287 Change-Id: I5ac7664bb885f560725327e20c0f59a1c0a3ccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5002120 Auto-Submit: Jonathan Hao <phao@chromium.org> Reviewed-by: Yifan Luo <lyf@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1220560}

… frame test resources., a=testonly Automatic update from web-platform-tests [Private Network Access] Unrename fenced frame test resources. The spec has been renamed back to Private Network Access. WICG/private-network-access#106 Bug: 1418287 Change-Id: I5ac7664bb885f560725327e20c0f59a1c0a3ccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5002120 Auto-Submit: Jonathan Hao <phao@chromium.org> Reviewed-by: Yifan Luo <lyf@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1220560} -- wpt-commits: b11c8390f4b279a57d267bcdfc98472064a53e8f wpt-pr: 42975

… frame test resources., a=testonly Automatic update from web-platform-tests [Private Network Access] Unrename fenced frame test resources. The spec has been renamed back to Private Network Access. WICG/private-network-access#106 Bug: 1418287 Change-Id: I5ac7664bb885f560725327e20c0f59a1c0a3ccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5002120 Auto-Submit: Jonathan Hao <phaochromium.org> Reviewed-by: Yifan Luo <lyfchromium.org> Commit-Queue: Yifan Luo <lyfchromium.org> Cr-Commit-Position: refs/heads/main{#1220560} -- wpt-commits: b11c8390f4b279a57d267bcdfc98472064a53e8f wpt-pr: 42975 UltraBlame original commit: a415f0ee6455140398c36f55e5ceaae6b3b73fe4

… frame test resources., a=testonly Automatic update from web-platform-tests [Private Network Access] Unrename fenced frame test resources. The spec has been renamed back to Private Network Access. WICG/private-network-access#106 Bug: 1418287 Change-Id: I5ac7664bb885f560725327e20c0f59a1c0a3ccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5002120 Auto-Submit: Jonathan Hao <phao@chromium.org> Reviewed-by: Yifan Luo <lyf@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1220560} -- wpt-commits: b11c8390f4b279a57d267bcdfc98472064a53e8f wpt-pr: 42975

… frame test resources., a=testonly Automatic update from web-platform-tests [Private Network Access] Unrename fenced frame test resources. The spec has been renamed back to Private Network Access. WICG/private-network-access#106 Bug: 1418287 Change-Id: I5ac7664bb885f560725327e20c0f59a1c0a3ccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5002120 Auto-Submit: Jonathan Hao <phaochromium.org> Reviewed-by: Yifan Luo <lyfchromium.org> Commit-Queue: Yifan Luo <lyfchromium.org> Cr-Commit-Position: refs/heads/main{#1220560} -- wpt-commits: b11c8390f4b279a57d267bcdfc98472064a53e8f wpt-pr: 42975 UltraBlame original commit: eb2bf3b830f0624e48c719c16ef243bdba708b6d

letitz added 2 commits May 25, 2023 18:04

Rename to Private Network Access.

def5455

Unrename shortname.

301d423

letitz force-pushed the unrename branch from b50284c to def5455 Compare May 25, 2023 16:05

letitz added 5 commits June 7, 2023 16:20

Unrename in HOWTO and README.

9465ed5

Unrename in explainer.

52c975c

Unrename permission_prompt/*.

997fd28

Unrename in self-review.

86ab54f

Unrename links in spec.

876634c

johnathan79717 approved these changes Jun 7, 2023

View reviewed changes

letitz merged commit ac2c8aa into main Jun 7, 2023
2 checks passed

github-actions bot added a commit that referenced this pull request Jun 7, 2023

Merge pull request #106 from WICG/unrename

38b1f96

SHA: ac2c8aa Reason: push, by letitz Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

letitz deleted the unrename branch June 7, 2023 14:44

chromium-wpt-export-bot mentioned this pull request Jul 10, 2023

Revert "[Local Network Access] Rename private to local in WPTs" web-platform-tests/wpt#40948

Closed

chromium-wpt-export-bot mentioned this pull request Jul 11, 2023

Revert "[Local Network Access] Rename private to local in request.cc" web-platform-tests/wpt#40968

Merged

chromium-wpt-export-bot mentioned this pull request Nov 6, 2023

[Private Network Access] Unrename fenced frame test resources. web-platform-tests/wpt#42975

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename to Private Network Access. #106

Rename to Private Network Access. #106

letitz commented May 25, 2023

annevk commented May 25, 2023

letitz commented May 25, 2023

annevk commented May 25, 2023

letitz commented May 26, 2023

annevk commented May 26, 2023

annevk commented May 26, 2023

letitz commented May 26, 2023

letitz commented Jun 7, 2023

johnathan79717 left a comment

letitz commented Jun 7, 2023

Rename to Private Network Access. #106

Rename to Private Network Access. #106

Conversation

letitz commented May 25, 2023

annevk commented May 25, 2023

letitz commented May 25, 2023

annevk commented May 25, 2023

letitz commented May 26, 2023

annevk commented May 26, 2023

annevk commented May 26, 2023

letitz commented May 26, 2023

letitz commented Jun 7, 2023

johnathan79717 left a comment

Choose a reason for hiding this comment

letitz commented Jun 7, 2023