Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename private to local #97

Merged
merged 7 commits into from
Feb 24, 2023
Merged

Rename private to local #97

merged 7 commits into from
Feb 24, 2023

Conversation

johnathan79717
Copy link
Collaborator

@johnathan79717 johnathan79717 commented Jan 18, 2023 •
edited
Loading

Fixes #91

@yoavweiss
Copy link
Collaborator

Hey @johnathan79717 - can you join the WICG to appease the IPR bots? :)

@johnathan79717 johnathan79717 changed the title Rename private to local [WIP] Rename private to local Jan 20, 2023
@johnathan79717
Copy link
Collaborator Author

Ah right. I requested to join WICG just now.

I have kept the header names the same until we decide what to do with it. I'll probably need to modify the explainers if we're gonna go through with this. Did I miss anything else?

@annevk
Copy link

annevk commented Jan 20, 2023

Please file explicit follow-up issues for things that are not renamed since you plan on closing the initial issue once this lands.

@johnathan79717
Copy link
Collaborator Author

Please file explicit follow-up issues for things that are not renamed since you plan on closing the initial issue once this lands.

Good point. I removed the keyword in the description so it should not close the initial issue now.

@johnathan79717
Copy link
Collaborator Author

Closing this as we decided against renaming. See #97

@johnathan79717 johnathan79717 deleted the rename-private-to-local branch January 25, 2023 15:19
@johnathan79717 johnathan79717 restored the rename-private-to-local branch January 27, 2023 16:01
@johnathan79717
Copy link
Collaborator Author

Reopening this PR since renaming is back on the table.

@johnathan79717 johnathan79717 marked this pull request as ready for review February 21, 2023 16:20
@johnathan79717 johnathan79717 changed the title [WIP] Rename private to local Rename private to local Feb 21, 2023
@letitz letitz mentioned this pull request Feb 21, 2023
Open
@letitz
Copy link
Collaborator

letitz commented Feb 23, 2023

Let me know when this is ready for review.

@johnathan79717
Copy link
Collaborator Author

Let me know when this is ready for review.

It is ready for review. 😄

@letitz
Copy link
Collaborator

letitz commented Feb 23, 2023

Perfect! I shall start reviewing then :)

letitz
letitz requested changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@letitz letitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we also want to update the base explainer.md file, right?

HOWTO.md Show resolved Hide resolved
README.md Show resolved Hide resolved
letitz
letitz requested changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@letitz letitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! One last suggestion and we can merge.

README.md Outdated Show resolved Hide resolved
@letitz letitz merged commit 72aa00c into WICG:main Feb 24, 2023
@johnathan79717 johnathan79717 deleted the rename-private-to-local branch February 27, 2023 10:02
aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 15, 2023
@johnathan79717
[Local Network Access] Rename private to local in web_view_browsertes…
cdd0a01 
…t.cc

In WICG/private-network-access#91, we decided to
rename Private Network Access to Local Network Access. The spec has
already been renamed in
WICG/private-network-access#97. The latest spec:
https://wicg.github.io/local-network-access/

This CL renames PrivateNetwork to LocalNetwork in
web_view_browsertest.cc.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287

Change-Id: I52fa91a66f225f7076cc1f1d4a9068c0ea880d82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335665
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Auto-Submit: Jonathan Hao <phao@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1117536}
aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 15, 2023
@johnathan79717
[Local Network Access] Rename content browser clients from private to…
285a3d7 
… local

In WICG/private-network-access#91, we decided to
rename Private Network Access to Local Network Access. The spec has
already been renamed in
WICG/private-network-access#97. The latest spec:
https://wicg.github.io/local-network-access/

This CL renames PrivateNetwork to LocalNetwork in content browser
clients.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287
Change-Id: Ied4716aa17e0c401a147e520341def36202fd31f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334479
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1117583}
aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 15, 2023
@johnathan79717
[Local Network Access] Rename private to local in interest_group_brow…
c6a9a9a 
…sertest.cc

In WICG/private-network-access#91, we decided to
rename Private Network Access to Local Network Access. The spec has
already been renamed in
WICG/private-network-access#97. The latest spec:
https://wicg.github.io/local-network-access/

This CL renames PrivateNetwork to LocalNetwork in
interest_group_browsertest.cc.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287

Change-Id: If1f8bbc9c5e8d87c8761dcf33ba41abd60114da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336326
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Auto-Submit: Jonathan Hao <phao@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1117589}
aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 16, 2023
@johnathan79717
[Local Network Access] Rename private to local in web_mitigation_metr…
7893736 
…ics.md

In WICG/private-network-access#91, we decided to
rename Private Network Access to Local Network Access. The spec has
already been renamed in
WICG/private-network-access#97. The latest spec:
https://wicg.github.io/local-network-access/

This CL renames PrivateNetwork to LocalNetwork in
web_mitigation_metrics.md.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287
Change-Id: If5d23739cba049908731f5fa97aff9f79a4037cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334390
Reviewed-by: Titouan Rigoudy <titouan@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118030}
aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 16, 2023
@johnathan79717
[Local Network Access] Rename net log event from private to local
0e5a66b 
In WICG/private-network-access#91, we decided to
rename Private Network Access to Local Network Access. The spec has
already been renamed in
WICG/private-network-access#97. The latest spec:
https://wicg.github.io/local-network-access/

This CL renames PrivateNetwork to LocalNetwork in net log events.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287
Change-Id: Idc3dcaee7d761b64d0d92ed393899334445e0541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336324
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118082}
aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 16, 2023
@johnathan79717
[Local Network Access] Rename net error from private to local
601e0d1 
In WICG/private-network-access#91, we decided to
rename Private Network Access to Local Network Access. The spec has
already been renamed in
WICG/private-network-access#97. The latest spec:
https://wicg.github.io/local-network-access/

This CL renames PrivateNetwork to LocalNetwork in net errors.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287
Change-Id: Id6338a3efb6ab2e5f31a8488240e611e8a7ffc47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334570
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118158}
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 28, 2023
@johnathan79717 @marcoscaceres
[Local Network Access] Rename private to local in request.cc
d9ee5ef 
In WICG/private-network-access#91, we decided to
rename (public, private, local) IP address spaces to (public, local,
loopback). The spec has already been renamed in
WICG/private-network-access#97.
New spec:
https://wicg.github.io/local-network-access/#ip-address-space-heading

This CL renames the string representation in request.cc. It also updates
a mixed content wpt because it uses targetAddressSpace defined in
Request.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287
Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1115707}
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 28, 2023
@johnathan79717 @marcoscaceres
[Local Network Access] Rename private to local in WPTs
f8416c1 
In WICG/private-network-access#91, we decided to
rename Private Network Access to Local Network Access. The spec has
already been renamed in
WICG/private-network-access#97. The latest spec:
https://wicg.github.io/local-network-access/

This CL renames PrivateNetwork to LocalNetwork in wpt file names.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287
Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033
Commit-Queue: Jonathan Hao <phao@chromium.org>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Cr-Commit-Position: refs/heads/main@{#1115802}
cookiecrook pushed a commit to cookiecrook/wpt that referenced this pull request Mar 29, 2023
@johnathan79717 @cookiecrook
[Local Network Access] Rename private to local in request.cc
37b3330 
In WICG/private-network-access#91, we decided to
rename (public, private, local) IP address spaces to (public, local,
loopback). The spec has already been renamed in
WICG/private-network-access#97.
New spec:
https://wicg.github.io/local-network-access/#ip-address-space-heading

This CL renames the string representation in request.cc. It also updates
a mixed content wpt because it uses targetAddressSpace defined in
Request.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287
Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1115707}
cookiecrook pushed a commit to cookiecrook/wpt that referenced this pull request Mar 29, 2023
@johnathan79717 @cookiecrook
[Local Network Access] Rename private to local in WPTs
1c45bcb 
In WICG/private-network-access#91, we decided to
rename Private Network Access to Local Network Access. The spec has
already been renamed in
WICG/private-network-access#97. The latest spec:
https://wicg.github.io/local-network-access/

This CL renames PrivateNetwork to LocalNetwork in wpt file names.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287
Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033
Commit-Queue: Jonathan Hao <phao@chromium.org>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Cr-Commit-Position: refs/heads/main@{#1115802}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 30, 2023
@johnathan79717 @moz-wptsync-bot
Bug 1820848 [wpt PR 38855] - [Local Network Access] Rename private to…
e9b1828 
… local in request.cc, a=testonly

Automatic update from web-platform-tests
[Local Network Access] Rename private to local in request.cc

In WICG/private-network-access#91, we decided to
rename (public, private, local) IP address spaces to (public, local,
loopback). The spec has already been renamed in
WICG/private-network-access#97.
New spec:
https://wicg.github.io/local-network-access/#ip-address-space-heading

This CL renames the string representation in request.cc. It also updates
a mixed content wpt because it uses targetAddressSpace defined in
Request.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287
Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1115707}

--

wpt-commits: 4af24bc53abf0e57acfc0e2c2d3ff62787e79c79
wpt-pr: 38855
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 30, 2023
@johnathan79717 @moz-wptsync-bot
Bug 1821692 [wpt PR 38935] - [Local Network Access] Rename private to…
2d63fe0 
… local in WPTs, a=testonly

Automatic update from web-platform-tests
[Local Network Access] Rename private to local in WPTs

In WICG/private-network-access#91, we decided to
rename Private Network Access to Local Network Access. The spec has
already been renamed in
WICG/private-network-access#97. The latest spec:
https://wicg.github.io/local-network-access/

This CL renames PrivateNetwork to LocalNetwork in wpt file names.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287
Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033
Commit-Queue: Jonathan Hao <phao@chromium.org>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Cr-Commit-Position: refs/heads/main@{#1115802}

--

wpt-commits: d7f32fa18f99177e1e5834b3995e33f28d1865b5
wpt-pr: 38935
cookiecrook pushed a commit to cookiecrook/wpt that referenced this pull request Apr 8, 2023
@johnathan79717 @cookiecrook
[Local Network Access] Rename private to local in request.cc
52d10b6 
In WICG/private-network-access#91, we decided to
rename (public, private, local) IP address spaces to (public, local,
loopback). The spec has already been renamed in
WICG/private-network-access#97.
New spec:
https://wicg.github.io/local-network-access/#ip-address-space-heading

This CL renames the string representation in request.cc. It also updates
a mixed content wpt because it uses targetAddressSpace defined in
Request.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287
Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1115707}
cookiecrook pushed a commit to cookiecrook/wpt that referenced this pull request Apr 8, 2023
@johnathan79717 @cookiecrook
[Local Network Access] Rename private to local in WPTs
2886350 
In WICG/private-network-access#91, we decided to
rename Private Network Access to Local Network Access. The spec has
already been renamed in
WICG/private-network-access#97. The latest spec:
https://wicg.github.io/local-network-access/

This CL renames PrivateNetwork to LocalNetwork in wpt file names.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287
Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033
Commit-Queue: Jonathan Hao <phao@chromium.org>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Cr-Commit-Position: refs/heads/main@{#1115802}
@latin-1 latin-1 mentioned this pull request Apr 9, 2023
Merged
4 tasks
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jul 10, 2023
Closed
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 10, 2023
@johnathan79717 @chromium-wpt-export-bot
Revert "[Local Network Access] Rename private to local in WPTs"
91da888 
This reverts commit 09f21d8c48ebc54193b12874c895648c69dfbe92.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in WPTs
>
> In WICG/private-network-access#91, we decided to
> rename Private Network Access to Local Network Access. The spec has
> already been renamed in
> WICG/private-network-access#97. The latest spec:
> https://wicg.github.io/local-network-access/
>
> This CL renames PrivateNetwork to LocalNetwork in wpt file names.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Reviewed-by: Weizhong Xia <weizhong@google.com>
> Cr-Commit-Position: refs/heads/main@{#1115802}

Bug: 1418287
Change-Id: I8f29e58c4a0e8741be98bc9fd640510e1473e61c
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 10, 2023
@johnathan79717
Revert "[Local Network Access] Rename private to local in web_mitigat…
56cdc7a 
…ion_metrics.md"

This reverts commit 7893736.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in web_mitigation_metrics.md
>
> In WICG/private-network-access#91, we decided to
> rename Private Network Access to Local Network Access. The spec has
> already been renamed in
> WICG/private-network-access#97. The latest spec:
> https://wicg.github.io/local-network-access/
>
> This CL renames PrivateNetwork to LocalNetwork in
> web_mitigation_metrics.md.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: If5d23739cba049908731f5fa97aff9f79a4037cf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334390
> Reviewed-by: Titouan Rigoudy <titouan@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1118030}

Bug: 1418287
Change-Id: Icc21a4fc48a12e85038c017a1f0821a6660f0f26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670561
Commit-Queue: Jonathan Hao <phao@chromium.org>
Reviewed-by: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168121}
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 10, 2023
@johnathan79717
Revert "[Local Network Access] Rename private to local in interest_gr…
f076086 
…oup_browsertest.cc"

This reverts commit c6a9a9a.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in interest_group_browsertest.cc
>
> In WICG/private-network-access#91, we decided to
> rename Private Network Access to Local Network Access. The spec has
> already been renamed in
> WICG/private-network-access#97. The latest spec:
> https://wicg.github.io/local-network-access/
>
> This CL renames PrivateNetwork to LocalNetwork in
> interest_group_browsertest.cc.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
>
> Change-Id: If1f8bbc9c5e8d87c8761dcf33ba41abd60114da0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336326
> Reviewed-by: Caleb Raitto <caraitto@chromium.org>
> Auto-Submit: Jonathan Hao <phao@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1117589}

Bug: 1418287
Change-Id: I476f0f99ee9d6192ad6ffa7080a70c240a1e9ad4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4669624
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168148}
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 10, 2023
@johnathan79717
Revert "[Local Network Access] Rename private to local in web_view_br…
8c9f372 
…owsertest.cc"

This reverts commit cdd0a01.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in web_view_browsertest.cc
>
> In WICG/private-network-access#91, we decided to
> rename Private Network Access to Local Network Access. The spec has
> already been renamed in
> WICG/private-network-access#97. The latest spec:
> https://wicg.github.io/local-network-access/
>
> This CL renames PrivateNetwork to LocalNetwork in
> web_view_browsertest.cc.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
>
> Change-Id: I52fa91a66f225f7076cc1f1d4a9068c0ea880d82
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335665
> Reviewed-by: Kevin McNee <mcnee@chromium.org>
> Auto-Submit: Jonathan Hao <phao@chromium.org>
> Reviewed-by: Bo Liu <boliu@chromium.org>
> Commit-Queue: Bo Liu <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1117536}

Bug: 1418287
Change-Id: I4658cb3f7ee33e7ab89c0a290dc551db79022828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4671591
Reviewed-by: Bo Liu <boliu@chromium.org>
Auto-Submit: Jonathan Hao <phao@chromium.org>
Quick-Run: Jonathan Hao <phao@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168202}
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 10, 2023
@johnathan79717
Revert "[Local Network Access] Rename content setting from private to…
7c8be54 
… local"

This reverts commit 262019a.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename content setting from private to local
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback) and rename the spec to Local Network Access. The spec has
> already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the occurrences in content settings.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: I5f1e6bfc5fcda6598e761eb201274ea9409609f8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335304
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1117088}

Bug: 1418287
Change-Id: I3a3afd97546650506410d57b81831ee63404dc36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670562
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168233}
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jul 11, 2023
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 11, 2023
@johnathan79717 @chromium-wpt-export-bot
Revert "[Local Network Access] Rename private to local in request.cc"
a176872 
This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 11, 2023
@johnathan79717 @chromium-wpt-export-bot
Revert "[Local Network Access] Rename private to local in request.cc"
e8cf07a 
This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Auto-Submit: Jonathan Hao <phao@chromium.org>
Quick-Run: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168815}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 11, 2023
@johnathan79717 @chromium-wpt-export-bot
Revert "[Local Network Access] Rename private to local in request.cc"
0b9e87d 
This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Auto-Submit: Jonathan Hao <phao@chromium.org>
Quick-Run: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168815}
jgraham pushed a commit to web-platform-tests/rfcs that referenced this pull request Jul 18, 2023
@johnathan79717
Rename private to local in address space overrides (#135)
aaaa99b 
In WICG/private-network-access#91, we decided to
rename Private Network Access to Local Network Access. The spec has
already been renamed in
WICG/private-network-access#97. The latest spec:
https://wicg.github.io/local-network-access/

Chromium has also renamed private to local in
https://source.chromium.org/chromium/chromium/src/+/d5b320062c4982d2e215386e068826f8bc97c512 so the ip-address-overrides switch value needs to be updated too.

This PR makes the corresponding changes in the RFC.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 20, 2023
@johnathan79717 @moz-wptsync-bot
Bug 1842883 [wpt PR 40968] - Revert "[Local Network Access] Rename pr…
55f0079 
…ivate to local in request.cc", a=testonly

Automatic update from web-platform-tests
Revert "[Local Network Access] Rename private to local in request.cc"

This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Auto-Submit: Jonathan Hao <phao@chromium.org>
Quick-Run: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168815}

--

wpt-commits: 0b9e87dcaa97a472760b165f20679338ddcbf30b
wpt-pr: 40968
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jul 21, 2023
@marco-c
Bug 1842883 [wpt PR 40968] - Revert "[Local Network Access] Rename pr…
8b488ac 
…ivate to local in request.cc", a=testonly

Automatic update from web-platform-tests
Revert "[Local Network Access] Rename private to local in request.cc"

This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamychromium.org>
> Commit-Queue: Jonathan Hao <phaochromium.org>
> Cr-Commit-Position: refs/heads/main{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564
Reviewed-by: Arthur Hemery <ahemerychromium.org>
Commit-Queue: Arthur Hemery <ahemerychromium.org>
Auto-Submit: Jonathan Hao <phaochromium.org>
Quick-Run: Jonathan Hao <phaochromium.org>
Cr-Commit-Position: refs/heads/main{#1168815}

--

wpt-commits: 0b9e87dcaa97a472760b165f20679338ddcbf30b
wpt-pr: 40968

UltraBlame original commit: 3363e3ba006e3d6813284cdf2adfcade6c21df88
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Jul 21, 2023
@marco-c
Bug 1842883 [wpt PR 40968] - Revert "[Local Network Access] Rename pr…
7dd24fe 
…ivate to local in request.cc", a=testonly

Automatic update from web-platform-tests
Revert "[Local Network Access] Rename private to local in request.cc"

This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamychromium.org>
> Commit-Queue: Jonathan Hao <phaochromium.org>
> Cr-Commit-Position: refs/heads/main{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564
Reviewed-by: Arthur Hemery <ahemerychromium.org>
Commit-Queue: Arthur Hemery <ahemerychromium.org>
Auto-Submit: Jonathan Hao <phaochromium.org>
Quick-Run: Jonathan Hao <phaochromium.org>
Cr-Commit-Position: refs/heads/main{#1168815}

--

wpt-commits: 0b9e87dcaa97a472760b165f20679338ddcbf30b
wpt-pr: 40968

UltraBlame original commit: 3363e3ba006e3d6813284cdf2adfcade6c21df88
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Jul 21, 2023
@marco-c
Bug 1842883 [wpt PR 40968] - Revert "[Local Network Access] Rename pr…
984f1b2 
…ivate to local in request.cc", a=testonly

Automatic update from web-platform-tests
Revert "[Local Network Access] Rename private to local in request.cc"

This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamychromium.org>
> Commit-Queue: Jonathan Hao <phaochromium.org>
> Cr-Commit-Position: refs/heads/main{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564
Reviewed-by: Arthur Hemery <ahemerychromium.org>
Commit-Queue: Arthur Hemery <ahemerychromium.org>
Auto-Submit: Jonathan Hao <phaochromium.org>
Quick-Run: Jonathan Hao <phaochromium.org>
Cr-Commit-Position: refs/heads/main{#1168815}

--

wpt-commits: 0b9e87dcaa97a472760b165f20679338ddcbf30b
wpt-pr: 40968

UltraBlame original commit: 3363e3ba006e3d6813284cdf2adfcade6c21df88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@letitz letitz letitz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider avoiding the use of the word "private"
4 participants
@johnathan79717 @yoavweiss @annevk @letitz