-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ForceLoadAtTop Document Policy #131
Conversation
8def939
to
192986f
Compare
@clelland: I added some spec text for the ForceLoadAtTop document policy, does this look about right? The document policy spec mentions there's a registry of features but I can't find one. If there is one we could add this to it. |
index.bs
Outdated
navigating-to-text-fragment section --> | ||
|
||
This specification defines a <a href="https://w3c.github.io/webappsec-permissions-policy/document-policy.html#configuration-point">configuration point</a> | ||
in [[!document-policy|Document Policy]] with name "force-load-at-top". It is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would say that it "has" a type of "boolean" (or just that "its type is boolean")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
index.bs
Outdated
"status": "ED", | ||
"publisher": "W3C", | ||
"deliveredBy": [ | ||
"https://w3c.github.io/webappsec-permissions-policy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably doesn't matter for an inline biblio ref, but this should be deliveredby "https://www.w3.org/2011/webappsec/" (URL points to the WG)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done. (btw, let me know if there's a way to reference the existing spec - I couldn't get it to work and I assume it's because Document-Policy isn't in specref yet.)
index.bs
Outdated
This otherwise case is the same as the current step 3.3. | ||
</div> | ||
3. <a href="https://w3c.github.io/webappsec-permissions-policy/document-policy.html#algo-get-policy-value">Get | ||
the document policy value</a> of "force-load-at-top" for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can just be "Get the policy value for force-load-at-top
in the Document"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
This looks good -- just a couple places where I would have worded things differently, but nothing big. Re: registries, I think you'd be the first entry, so I should probably get on adding that :) |
Thanks! Let me know when you get the registry up and we can add this to it. |
Fixes #80
Preview | Diff