Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ForceLoadAtTop Document Policy #131

Merged
merged 2 commits into from
Aug 13, 2020

Conversation

bokand
Copy link
Collaborator

@bokand bokand commented Aug 7, 2020

Fixes #80


Preview | Diff

@bokand
Copy link
Collaborator Author

bokand commented Aug 7, 2020

@clelland: I added some spec text for the ForceLoadAtTop document policy, does this look about right?

The document policy spec mentions there's a registry of features but I can't find one. If there is one we could add this to it.

index.bs Outdated
navigating-to-text-fragment section -->

This specification defines a <a href="https://w3c.github.io/webappsec-permissions-policy/document-policy.html#configuration-point">configuration point</a>
in [[!document-policy|Document Policy]] with name "force-load-at-top". It is a

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would say that it "has" a type of "boolean" (or just that "its type is boolean")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

index.bs Outdated
"status": "ED",
"publisher": "W3C",
"deliveredBy": [
"https://w3c.github.io/webappsec-permissions-policy"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably doesn't matter for an inline biblio ref, but this should be deliveredby "https://www.w3.org/2011/webappsec/" (URL points to the WG)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done. (btw, let me know if there's a way to reference the existing spec - I couldn't get it to work and I assume it's because Document-Policy isn't in specref yet.)

index.bs Outdated
This otherwise case is the same as the current step 3.3.
</div>
3. <a href="https://w3c.github.io/webappsec-permissions-policy/document-policy.html#algo-get-policy-value">Get
the document policy value</a> of "force-load-at-top" for the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can just be "Get the policy value for force-load-at-top in the Document"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@clelland
Copy link

This looks good -- just a couple places where I would have worded things differently, but nothing big.

Re: registries, I think you'd be the first entry, so I should probably get on adding that :)

@bokand
Copy link
Collaborator Author

bokand commented Aug 13, 2020

Thanks! Let me know when you get the registry up and we can add this to it.

@bokand bokand merged commit 60f5f63 into WICG:master Aug 13, 2020
@bokand bokand deleted the documentPolicyIntegration branch August 13, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add opt-in/opt-out mechanism
2 participants