-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spec] Merge WindowSharedStorage interface with SharedStorage #154
Comments
(Made a very minor edit just FYI, let me know if it looks wrong). |
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
May 8, 2024
This allows the runtime feature to be overridden by the default state of the base::Feature. Note: Fledge base::Feature is not enabled by default yet, therefore we leave the behavior unchanged for now. Shared Storage API I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/dZ0NRwh7cvs/m/RHvbZNp_AgAJ Fenced Frames I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/tpw8wW0VenQ/m/mePLTiHlDQAJ Topics API I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/PN_aE-X-f9U/m/SweKUn3lBAAJ Private Aggregation API I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/8cKaLstq2QQ/m/JENzsATUBgAJ List of items that are different between I2S and the current implementation: 1. WICG/fenced-frame#155 2. WICG/shared-storage#154 3. https://issues.chromium.org/issues/337055574 Bug: 331926920 Change-Id: I5d2706fabbc6f771d50adfdf358d6daca3322223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5420588 Reviewed-by: Domenic Denicola <domenic@chromium.org> Reviewed-by: Andrew Verge <averge@chromium.org> Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Commit-Queue: Nan Lin <linnan@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Reviewed-by: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#1298072}
xyaoinum
added a commit
that referenced
this issue
Aug 13, 2024
This addresses the misalignment between spec and code: #154. For the spec, we remove `WindowSharedStorage` and `WorkletSharedStorage` interfaces, and use `[Exposed=Window/SharedStorageWorklet]` to control the exposure of individual fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Today, the Chrome code and the spec don't match:
Exposed=(Window, SharedStorageWorklet) interface SharedStorage {...}
interface, and it adds[Exposed=SharedStorageWorklet]
to prevent individual methods from being exposed fromwindow.sharedStorage
when inside of aWindow
global specifically.Exposed=(Window, SharedStorageWorklet) interface SharedStorage
, and puts the Window-only methods into a[Exposed=(Window)] interface WindowSharedStorage : SharedStorage {}
.To align with the existing code's functionality,
WindowSharedStorage
should be merged intoSharedStorage
within the spec.The text was updated successfully, but these errors were encountered: