-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support spatial-navigation-action
CSS Property
#171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add spatial-navigation-behavior CSS Property
navbeforefocus and navnotarget event are cancelable, but the previous polyfill didn't support to cancel them. The canceling process of those events are added in the processing model.
But why? why it doesn't work??
The demo only moves focus (don't manual scrolling), but it caused the scrolling at the end of the processing model. Therefore fix this undesirable behavior.
Simple version of scroller demo
Add the demo for introducing 'spatial-navigation-action' css property
Add spatial-navigation-action CSS property
* Use event handler * Minor : use 'action' instead of 'behavior'
Followed by the latest spec, (https://drafts.csswg.org/css-nav-1/#propdef-spatial-navigation-action) the `spatial-navigation-action` shouldn't be inherited.
* Add the meaningless text inside the scroller to verify the 'focus' value works properly * If 'focus' is given to `spatial-navigation-action`, "spatnav only moves focus" (no scrolling)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spatial-navigation-action
CSS Property--spatial-navigation-action
CSS Custom propertygetCSSSpatNavAction(element)
functionfocusOnly()
function for implementing behavior whenspatial-navigation-action: focus
navbeforescroll
Navigation Eventspatial-navigation-action
worksspatial-navigation-action
works