Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spatial-navigation-action CSS Property #171

Merged
merged 47 commits into from
Apr 11, 2019

Conversation

jihyerish
Copy link
Collaborator

  • Add the feature supports for spatial-navigation-action CSS Property
    • --spatial-navigation-action CSS Custom property
    • getCSSSpatNavAction(element) function
    • focusOnly() function for implementing behavior when spatial-navigation-action: focus
  • Remove navbeforescroll Navigation Event
  • Add the sample for how spatial-navigation-action works
  • Add the infinite scroller demo for showing how spatial-navigation-action works

Jihye Hong and others added 30 commits February 20, 2019 17:40
Add spatial-navigation-behavior CSS Property
navbeforefocus and navnotarget event are cancelable, but the previous polyfill didn't support to cancel them.

The canceling process of those events are added in the processing model.
But why? why it doesn't work??
The demo only moves focus (don't manual scrolling), but it caused the scrolling at the end of the processing model.
Therefore fix this undesirable behavior.
Simple version of scroller demo
Jihye Hong added 17 commits March 19, 2019 14:36
Add the demo for introducing 'spatial-navigation-action' css property
Add spatial-navigation-action CSS property
* Use event handler
* Minor : use 'action' instead of 'behavior'
Followed by the latest spec,
(https://drafts.csswg.org/css-nav-1/#propdef-spatial-navigation-action)
the `spatial-navigation-action` shouldn't be inherited.
* Add the meaningless text inside the scroller to verify the 'focus' value works properly
* If 'focus' is given to `spatial-navigation-action`, "spatnav only moves focus" (no scrolling)
@jihyerish jihyerish merged commit 11f3238 into master Apr 11, 2019
@jihyerish jihyerish deleted the polyfill-spatnav-action branch April 22, 2019 01:19
@jihyerish jihyerish restored the polyfill-spatnav-action branch May 14, 2019 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant