Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nullability from StorageBucketOptions members. #118

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

evanstade
Copy link
Collaborator

@evanstade evanstade commented Nov 29, 2023

They're already optional by default:
https://webidl.spec.whatwg.org/#dictionary-member-optional

Fixes #114


Preview | Diff

Copy link
Collaborator

@ayuishii ayuishii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@evanstade evanstade merged commit d87656b into WICG:main Dec 19, 2023
2 checks passed
@evanstade evanstade deleted the notnullable branch December 19, 2023 00:07
github-actions bot added a commit that referenced this pull request Dec 19, 2023
SHA: d87656b
Reason: push, by evanstade

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nullable dictionary members don't seem necessary
2 participants