Update explainer to include units for requestedSize and renderSize code examples. #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(just some context for reviewer): See #1141 (comment) for more details. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 19, 2024
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 22, 2024
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
xiaochen-z
changed the title
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 22, 2024
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 22, 2024
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 29, 2024
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
|
@JensenPaul This PR is ready for review. Thanks. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 1, 2024
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 1, 2024
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447954 Reviewed-by: Caleb Raitto <caraitto@chromium.org> Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1294870}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 1, 2024
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447954 Reviewed-by: Caleb Raitto <caraitto@chromium.org> Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1294870}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 6, 2024
…ze field to browserSignals of scoreAd., a=testonly Automatic update from web-platform-tests Protected Audience: Add missing renderSize field to browserSignals of scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447954 Reviewed-by: Caleb Raitto <caraitto@chromium.org> Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1294870} -- wpt-commits: 3c8f88bb2b952e67e70a7a896ef6b0cf259603f0 wpt-pr: 45802
ErichDonGubler
pushed a commit
to ErichDonGubler/firefox
that referenced
this pull request
May 10, 2024
…ze field to browserSignals of scoreAd., a=testonly Automatic update from web-platform-tests Protected Audience: Add missing renderSize field to browserSignals of scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447954 Reviewed-by: Caleb Raitto <caraitto@chromium.org> Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1294870} -- wpt-commits: 3c8f88bb2b952e67e70a7a896ef6b0cf259603f0 wpt-pr: 45802
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jun 6, 2024
…ze field to browserSignals of scoreAd., a=testonly Automatic update from web-platform-tests Protected Audience: Add missing renderSize field to browserSignals of scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447954 Reviewed-by: Caleb Raitto <caraitto@chromium.org> Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1294870} -- wpt-commits: 3c8f88bb2b952e67e70a7a896ef6b0cf259603f0 wpt-pr: 45802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
requestedSizeis a dictionary member of thebrowserSignalsargument to thegenerateBidfunction. The implementation ofrequestedSizeappends the size units when constructing it inbrowserSignals. However, the current explainer does not include units in the code example.Similarly for
renderSizeof thebrowserSignalsargument to thescoreAdfunction, it has not been implemented yet but we plan to append the unit as well. This is currently in progress in this CL.Also the "height" and "width" in these examples should be strings. The missing quotation marks are added. See spec for
requestedSize. Its type isrecord<DOMString, DOMString>.Related spec PR #1141 has been approved.