-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarification regarding renderSize in scoring browser signals #1088
Comments
I've also subsequently confirmed that this doesn't seem to be impacted by the presence of |
Right. One's interest group can include adSizes, sizeGroups and apply those to renderURLs but Chrome does not consume them (or at least does not include them in the Buyers and Sellers could use this metadata now prior to its application to k-anonymity. Buyers to signal renderURL size to bidding code versus a scheme within Speaking of sellers receiving bid size metadata, the |
@gtanzer is an expert on ad sizes. |
Hi @gtanzer we have run into this issue as we wanted to use the adSize information defined in our IGs in the generateBid function, could you please provide more information on the status of this? |
Tracking in https://issues.chromium.org/u/1/issues/333628467. I'm working on a fix. |
As I read that ticket, it will solve for sellers to use any size metadata buyers might provide in the |
Thanks @dmdabbs, I was about to ask the same, as our case is on the buyer side. @xiaochen-z could you please confirm if this is only covering the seller side of things, or would also be a buyer solution / buyer part will be dealt with in another ticket? Thanks. |
Sorry I'm not super familiar with Protected Audience. Is there another issue in |
The issue with generateBid will be handled separately. The only complication there is figuring out how to handle the initial auction vs. the fallback auction when non-k-anon options are removed. That isn't an issue for scoreAd so it's an easier fix. |
thank you @gtanzer . In the meantime I have also read the meeting minutes where the k-anon issue was discussed. Thanks for looking into this. |
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447954 Reviewed-by: Caleb Raitto <caraitto@chromium.org> Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1294870}
scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447954 Reviewed-by: Caleb Raitto <caraitto@chromium.org> Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1294870}
…ze field to browserSignals of scoreAd., a=testonly Automatic update from web-platform-tests Protected Audience: Add missing renderSize field to browserSignals of scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447954 Reviewed-by: Caleb Raitto <caraitto@chromium.org> Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1294870} -- wpt-commits: 3c8f88bb2b952e67e70a7a896ef6b0cf259603f0 wpt-pr: 45802
…ze field to browserSignals of scoreAd., a=testonly Automatic update from web-platform-tests Protected Audience: Add missing renderSize field to browserSignals of scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447954 Reviewed-by: Caleb Raitto <caraitto@chromium.org> Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1294870} -- wpt-commits: 3c8f88bb2b952e67e70a7a896ef6b0cf259603f0 wpt-pr: 45802
…ze field to browserSignals of scoreAd., a=testonly Automatic update from web-platform-tests Protected Audience: Add missing renderSize field to browserSignals of scoreAd. The Protected Audience explainer claims the browserSignals argument of scoreAd function should contain an optional field of renderSize. However, it is found that this has not been implemented. See: https://github.com/WICG/turtledove/blob/main/FLEDGE.md#:~:text=%27renderSize%27%3A%20%7Bwidth%3A%20100%2C%20height%3A%20200%7D%2C%20/*%20if%20specified%20in%20the%20bid%20*/ This CL implements this optional field to match what the explainer claims. See: WICG/turtledove#1088 Spec PR: WICG/turtledove#1141 Explainer PR: WICG/turtledove#1145 Bug: 333628467 Change-Id: I95d5ebb7ddbbeb50d0ac3618e22ed1e228ec32a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447954 Reviewed-by: Caleb Raitto <caraitto@chromium.org> Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1294870} -- wpt-commits: 3c8f88bb2b952e67e70a7a896ef6b0cf259603f0 wpt-pr: 45802
What is the status of providing size information to the bidding function? Not having this, makes it difficult to filter out ads which don't support the requested slot size. |
Howdy @tylerdev0. When
And, FWIW, how GAM selects a size: |
Yes, I see we get the requested size as part of the browser signals, however we don't get the Interest Groups' The impact is that we were planning on relying on the sizeGroup and adSizes definitions to filter out ads which don't support the requested slot size. I suppose we can duplicate that information in the ad metadata, but it would be preferable to just have the interest group's defined ad sizes provided to generateBid so that can be used directly for this purpose. |
Ah, yes. I'm with you there, @tylerdev0. At a Wed meeting (probably around my march comment above) when we were discussing sellers' You could raise it again in this Wednesday's call. We've both expressed our interest here in writing (albeit on an adjacent issue) to have this implemented. Might not hurt either to post a separate issue specifically requesting this. cc: @gtanzer |
Hi, We used the
This macro substitution mechanism seems to no longer work. Can you confirm that it is currently unreliable? If so, is the only valid mechanism now the use of the requestedSize array? Thanks in advance. |
According to https://github.com/WICG/turtledove/blob/main/FLEDGE.md#23-scoring-bids,
browserSignals
inscoreAd
should contain the following:However, when looking at the spec, https://wicg.github.io/turtledove/#structures,
ScoringBrowserSignals
doesn't seems to have any mention of thewidth
andheight
from theAdRender
object (cf. https://wicg.github.io/turtledove/#convert-an-ad-render):Using M124, despite bidding with a
render
object includingurl
,width
andheight
, I'm unable to observe therenderSize
inscoreAd
'sbrowserSignals
-- can you elaborate on when this value should be populated?(perhaps related -- #970 recently found another gap in the implementation, where the behaviour doesn't match the explainer -- could something similar be happening here)?
The text was updated successfully, but these errors were encountered: