Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec: Fix error and not requested cases around trusted bidding signals #1180

Merged
merged 9 commits into from
May 29, 2024
Merged

Spec: Fix error and not requested cases around trusted bidding signals #1180

merged 9 commits into from
May 29, 2024

Commits on May 16, 2024

  1. Spec: Fix error and not specified cases around trusted bidding signals 

    Trusted bidding signals do not have to be specified, and the fetches
can fail. In those cases, we will pass in null for the argument, while
the current spec didn't really handle them. Null is also passed in
when the requested keys are empty, rather than an empty dict.
    Maks Orlovich committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a393503 View commit details
    Browse the repository at this point in the history

  2. Formatting fix on note + edit the note

    Maks Orlovich committed May 16, 2024
    Configuration menu
    Copy the full SHA
    baf516a View commit details
    Browse the repository at this point in the history

  3. More context to the field.

    Maks Orlovich committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a7ddd41 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Easy part of feedback

    Maks Orlovich committed May 17, 2024
    Configuration menu
    Copy the full SHA
    d0076f8 View commit details
    Browse the repository at this point in the history

  2. Null checks on key

    Maks Orlovich committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8649f3b View commit details
    Browse the repository at this point in the history

  3. Clarify null key

    Maks Orlovich committed May 17, 2024
    Configuration menu
    Copy the full SHA
    bad43dc View commit details
    Browse the repository at this point in the history

  4. Add assert

    Maks Orlovich committed May 17, 2024
    Configuration menu
    Copy the full SHA
    ea69bf7 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Apply feedback

    Maks Orlovich committed May 29, 2024
    Configuration menu
    Copy the full SHA
    f4819f6 View commit details
    Browse the repository at this point in the history

  2. The booleans thing, too.

    Maks Orlovich committed May 29, 2024
    Configuration menu
    Copy the full SHA
    cafbfdb View commit details
    Browse the repository at this point in the history