Spec: Fix error and not requested cases around trusted bidding signals #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 16, 2024 11:04
Trusted bidding signals do not have to be specified, and the fetches can fail. In those cases, we will pass in null for the argument, while the current spec didn't really handle them. Null is also passed in when the requested keys are empty, rather than an empty dict.
This was referenced May 16, 2024
caraitto
suggested changes
May 16, 2024
added 2 commits
May 17, 2024 11:01
caraitto
suggested changes
May 17, 2024
caraitto
reviewed
May 17, 2024
caraitto
approved these changes
May 17, 2024
morlovich
requested review from
domfarolino and
miketaylr
and removed request for
domfarolino
domfarolino
reviewed
May 29, 2024
added 2 commits
May 29, 2024 11:03
domfarolino
approved these changes
May 29, 2024
github-actions bot
added a commit
to morlovich/turtledove
that referenced
this pull request
May 29, 2024
github-actions bot
added a commit
to qingxinwu/turtledove
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trusted bidding signals URL does not have to be specified, and the fetches can fail. In those cases, the Chrome implementation will pass in null for the argument, while the current spec didn't really handle them. Null is also passed in when the requested keys are empty, rather than an empty dict.
Preview | Diff