Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ad component reportEvent #541

Merged
merged 22 commits into from
Jun 12, 2023
Merged

Support for ad component reportEvent #541

merged 22 commits into from
Jun 12, 2023

Conversation

xiaochen-z
Copy link
Contributor

Update the explainer for support for ad component reportEvent #332.

@xiaochen-z xiaochen-z marked this pull request as ready for review April 14, 2023 14:17
Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
@miketaylr
Copy link
Collaborator

**ipr ** — PR has contribution issues. The following users' affiliation could not be determined: @xiaochen-z.
xiaochen-z is unknown, they need to link their GitHub account with a W3C account

@xiaochen-z can you link your github account with your w3c account so the IPR bot will be happy? See https://www.w3.org/users/myprofile/connectedaccounts - thanks!

@xiaochen-z
Copy link
Contributor Author

**ipr ** — PR has contribution issues. The following users' affiliation could not be determined: @xiaochen-z.
xiaochen-z is unknown, they need to link their GitHub account with a W3C account

@xiaochen-z can you link your github account with your w3c account so the IPR bot will be happy? See https://www.w3.org/users/myprofile/connectedaccounts - thanks!

Done, I've linked my account. It seems I also need to join the Web Platform Incubator Community Group. I've sent the request using the link.

@miketaylr
Copy link
Collaborator

Awesome, IPR is good now. Thanks!

Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
Copy link
Contributor

@shivanigithub shivanigithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % some comments, thanks!

Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
aarongable pushed a commit to chromium/chromium that referenced this pull request Apr 24, 2023
Updated FenceEvent's IDL to make eventData field optional.
1. No eventData: beacon is sent with an empty string for the eventData
field.
window.fence.reportEvent({
  eventType: 'click',
  destination: ['buyer']
});

2. Has eventData: beacon is sent with the given string for the
eventData field.
window.fence.reportEvent({
  eventType: 'click',
  eventData: 'this is a click',
  destination: ['buyer']
});

Pull request for updating the explainer:
WICG/turtledove#541

Bug: 1394499
Change-Id: I48d5554d0cc6b3ae56b161bca86fa65bffc2080f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4386613
Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org>
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1134909}
Fenced_Frames_Ads_Reporting.md Show resolved Hide resolved
Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
Fenced_Frames_Ads_Reporting.md Show resolved Hide resolved
xiaochen-z and others added 3 commits May 17, 2023 10:57
Co-authored-by: Paul Jensen <JensenPaul@users.noreply.github.com>
Mention click as an example for user activation.
Copy link
Contributor

@shivanigithub shivanigithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % nit

Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
@JensenPaul JensenPaul merged commit fe032ac into WICG:main Jun 12, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Jun 12, 2023
SHA: fe032ac
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to qingxinwu/turtledove that referenced this pull request Jun 12, 2023
SHA: fe032ac
Reason: push, by qingxinwu

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants