Spec skeleton for interacting with the fenced frame config mapping #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtanzer
changed the title
gtanzer
changed the title
gtanzer
force-pushed
the
construct-config
branch
from
05d82f9
to
524a1f0
Compare
jyasskin
reviewed
Jun 16, 2023
gtanzer
force-pushed
the
construct-config
branch
from
2129554
to
2019c08
Compare
domfarolino
reviewed
Jun 20, 2023
There was a problem hiding this comment.
There are a number of TODOs here which are hard to evaluate. It would be good to know how many of them are going to be resolved in this PR vs after.
Separately: will there be a follow-up to #593 (review) where we actually resolve the promise with a web-exposed FencedFrameConfig object that internally references the config struct?
domfarolino
reviewed
Jun 22, 2023
domfarolino
reviewed
Jun 26, 2023
JensenPaul
reviewed
Jun 27, 2023
JensenPaul
reviewed
Jun 27, 2023
|
I'll try closing and re-opening this to kick off the PR preview thing again, see if it is "fixed" now. |
domfarolino
reviewed
Jun 28, 2023
domfarolino
approved these changes
Jun 28, 2023
github-actions bot
added a commit
that referenced
this pull request
Jun 28, 2023
) SHA: e332640 Reason: push, by miketaylr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff