Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JoinAdInterestGroup/runAdAuction/sendReportTo checks for enrollment #766

Merged
merged 6 commits into from
Sep 8, 2023
Merged

JoinAdInterestGroup/runAdAuction/sendReportTo checks for enrollment #766

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8a8411
Check JoinAdInterestGroup's owner for enrollment
shivanigithub Aug 23, 2023
46d1d8a
include changes to runAdAuction as well
shivanigithub Aug 23, 2023
cb17017
include sendReportTo changes
shivanigithub Aug 23, 2023
d70afa9
snedReportTo returns w/o exception
shivanigithub Sep 8, 2023
bb50aa0
moved to "validate and convert auction ad config"
shivanigithub Sep 8, 2023
7d56903
fixed user agent link
shivanigithub Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,11 @@ This is detectable because it can change the set of fields that are read from th
|group|["{{GenerateBidInterestGroup/owner}}"].
1. If |interestGroup|'s [=interest group/owner=] is failure, or its [=url/scheme=] is not
"`https`", [=exception/throw=] a {{TypeError}}.
1. Optionally, [=exception/throw=] a "{{NotAllowedError}}" {{DOMException}}.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the best place to bail? Could this happen after (or before?) the first step (permissions policy check)?

We have the owner from group[owner] as soon as we enter into this method, right?.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is right after the step that parses the origin of the owner and checks if it's https. I don't think we can put it before the parsing step.


Note: This [=implementation-defined=] condition is intended to allow user
agents to decline for a number of reasons, for example the [=interest group/owner=]'s [=site=]
not being <a href="https://github.com/privacysandbox/attestation">enrolled</a>.
1. Set |interestGroup|'s [=interest group/name=] to |group|["{{GenerateBidInterestGroup/name}}"].
1. Set |interestGroup|'s [=interest group/priority=] to
|group|["{{AuctionAdInterestGroup/priority}}"].
Expand Down Expand Up @@ -831,6 +836,11 @@ To <dfn>validate and convert auction ad config</dfn> given an {{AuctionAdConfig}
1. Let |seller| be the result of [=parsing an origin=] with |config|["{{AuctionAdConfig/seller}}"].
1. If |seller| is failure, or its [=url/scheme=] is not "`https`", then [=exception/throw=] a
{{TypeError}}.
1. Optionally, [=exception/throw=] a "{{NotAllowedError}}" {{DOMException}}.

Note: This [=implementation-defined=] condition is intended to allow user
agents to decline for a number of reasons, for example the [=auctionConfig]'s seller's [=site=]
not being <a href="https://github.com/privacysandbox/attestation">enrolled</a>.
1. Set |auctionConfig|'s [=auction config/seller=] to |seller|.
1. Let |decisionLogicURL| be the result of running the [=URL parser=] on
|config|["{{AuctionAdConfig/decisionLogicURL}}"].
Expand Down Expand Up @@ -2563,6 +2573,11 @@ Each {{InterestGroupReportingScriptRunnerGlobalScope}} has a
set [=this=]'s [=relevant global object=]'s
[=InterestGroupReportingScriptRunnerGlobalScope/report url=] to failure
and [=exception/Throw=] a {{TypeError}}.
1. Optionally, return.

Note: This [=implementation-defined=] condition is intended to allow user
agents to decline for a number of reasons, for example the |parsedUrl|'s [=site=]
not being <a href="https://github.com/privacysandbox/attestation">enrolled</a>.
1. Set [=this=]'s [=relevant global object=]'s
[=InterestGroupReportingScriptRunnerGlobalScope/report url=] to |parsedUrl|.
</div>
Expand Down