Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec ad size macro substitution #801

Merged
merged 9 commits into from
Apr 2, 2024
Merged

Spec ad size macro substitution #801

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d5b92af
spec ad size macro
Sep 13, 2023
ea33de3
Small change to rerun checks
gtanzer Sep 22, 2023
92e1a86
Twiddle diff to rerun checks
gtanzer Sep 28, 2023
976f2fa
Add Issue: refs
gtanzer Apr 2, 2024
cf2411f
Clarify todo
gtanzer Apr 2, 2024
3585e8a
Merge branch 'main' into ad-size-macro
gtanzer Apr 2, 2024
dac9587
Update spec.bs
gtanzer Apr 2, 2024
49a9bb4
Update spec.bs
gtanzer Apr 2, 2024
6f7ecaa
fix
gtanzer Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 18 additions & 1 deletion spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,12 +819,29 @@ To <dfn>fill in a pending fenced frame config</dfn> given a [=fenced frame confi
1. Set |pendingConfig|'s [=fenced frame config/mapped url=]'s [=mapped url/value=] to
|replacedAdURL|.
1. Let |adSize| be |winningBid|'s [=generated bid/ad descriptor=]'s [=ad descriptor/size=].
1. Let |concreteAdSize| be the result of

Issue: resolving screen-relative sizes to pixel values for |adSize|.
(<a href="https://github.com/WICG/turtledove/issues/986">WICG/turtledove#986</a>)
1. Let |adWidthString| and |adHeightString| be the result of

Issue: converting |concreteAdSize| to strings.
(<a href="https://github.com/WICG/turtledove/issues/986">WICG/turtledove#986</a>)
1. Let |sizeMacroMap| be the [=ordered map=] «[ "{%AD_WIDTH%}" → |adWidthString|,
"{%AD_HEIGHT%}" → |adHeightString|, "${AD_WIDTH}" → |adWidthString|,
"${AD_HEIGHT}" → |adHeightString|]»
1. Set |pendingConfig|'s [=fenced frame config/mapped url=]'s [=mapped url/value=] to
the result of [=fencedframeutil/substituting macros=] with |sizeMacroMap| into |winningBid|'s
[=generated bid/ad descriptor=]'s [=ad descriptor/url=].
1. If |adSize| is not null:
1. Set |pendingConfig|'s [=fenced frame config/content size=] to a [=struct=] with the following
[=struct/items=]:
: [=content size/value=]
:: |adSize| TODO: Resolve screen-relative sizes and macros and cast this properly.
:: |concreteAdSize|.

Issue: Cast |concreteAdSize| into the format that is eventually chosen for
[=content size/value=].
(<a href="https://github.com/WICG/turtledove/issues/986">WICG/turtledove#986</a>)
: [=content size/visibility=]
:: "<a for=visibility>`opaque`</a>"
1. Set |pendingConfig|'s [=fenced frame config/interest group descriptor=]'s
Expand Down