Spec ad size macro substitution #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Garrett, is this PR ready for review by our spec mentor domfarolino? |
|
Yes |
1 task
domfarolino
reviewed
Oct 20, 2023
|
I believe this should be good to merge now @domfarolino |
domfarolino
approved these changes
Jan 20, 2024
|
@domfarolino @qingxinwu Finally addressed those tiny lingering comments and rebased. Assuming everything builds fine in the preview, should be good to merge. |
qingxinwu
reviewed
Apr 2, 2024
github-actions bot
added a commit
that referenced
this pull request
Apr 2, 2024
SHA: 3d9ccfe Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to qingxinwu/turtledove
that referenced
this pull request
Apr 2, 2024
SHA: 3d9ccfe Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec that ad sizes are macro'd into the mapped url with {%AD_WIDTH%}, {%AD_HEIGHT%}, ${AD_WIDTH}, and ${AD_HEIGHT}.
Preview | Diff