Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider limits on brand size (and possibly hints in general) #179

Closed
miketaylr opened this issue Jan 7, 2021 · 2 comments
Closed

Consider limits on brand size (and possibly hints in general) #179

miketaylr opened this issue Jan 7, 2021 · 2 comments
Assignees
@miketaylr

Comments

@miketaylr
Copy link
Collaborator

This came up in review for #178 (comment), and relates to WICG/client-hints-infrastructure#100 as well.
@miketaylr miketaylr mentioned this issue Jan 7, 2021
Merged
@miketaylr miketaylr mentioned this issue Feb 8, 2021
Open
@jwrosewell jwrosewell mentioned this issue Feb 10, 2021
Closed
@jwrosewell
Copy link

Suggest using a registry of keys and values rather than including this in the specification. See 200.

@miketaylr
Copy link
Collaborator Author

It's somewhat arbitrary, but let's pick 32 chars for now.

@miketaylr miketaylr self-assigned this Oct 25, 2021
miketaylr added a commit to miketaylr/ua-client-hints that referenced this issue Oct 25, 2021
@miketaylr
Issue WICG#179 - Add a size restriction to a brand name
5d51190
miketaylr added a commit that referenced this issue Oct 25, 2021
@miketaylr
Merge pull request #270 from miketaylr/issues/179/1
ab31750 
Issue #179 - Add a size restriction to a brand name
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 25, 2021
@miketaylr @chromium-wpt-export-bot
Update Sec-CH-UA tests: fix existing tests, and test brand size.
8f761a9 
As of WICG/ua-client-hints#179,
https://wicg.github.io/ua-client-hints/#user-agent-brand now requires
that a brand in a brand list not be longer than 32 bytes.

This CL adds a new test for the userAgentData.brands interface, and
modifies the existing sec-ch-ua HTTP tests.

Also, the existing sec-ch-ua HTTP tests were updated to more closely
reflect the current state of UA-CH ("UA" is not a valid token, and
"Accept-CH-Lifetime" is not shipping).

Bug: 1263180
Change-Id: Ifa7cbf18d67271e2dd1dc1d485f432d4ca9327fa
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 26, 2021
@miketaylr @chromium-wpt-export-bot
Update Sec-CH-UA tests: fix existing tests, and test brand size.
1aeba33 
As of WICG/ua-client-hints#179,
https://wicg.github.io/ua-client-hints/#user-agent-brand now requires
that a brand in a brand list not be longer than 32 bytes.

This CL adds a new test for the userAgentData.brands interface, and
modifies the existing sec-ch-ua HTTP tests.

Also, the existing sec-ch-ua HTTP tests were updated to more closely
reflect the current state of UA-CH ("UA" is not a valid token, and
"Accept-CH-Lifetime" is not shipping).

Bug: 1263180
Change-Id: Ifa7cbf18d67271e2dd1dc1d485f432d4ca9327fa
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 26, 2021
@miketaylr @chromium-wpt-export-bot
Update Sec-CH-UA tests: fix existing tests, and test brand size.
9953a6a 
As of WICG/ua-client-hints#179,
https://wicg.github.io/ua-client-hints/#user-agent-brand now requires
that a brand in a brand list not be longer than 32 bytes.

This CL adds a new test for the userAgentData.brands interface, and
modifies the existing sec-ch-ua HTTP tests.

Also, the existing sec-ch-ua HTTP tests were updated to more closely
reflect the current state of UA-CH ("UA" is not a valid token, and
"Accept-CH-Lifetime" is not shipping).

Bug: 1263180
Change-Id: Ifa7cbf18d67271e2dd1dc1d485f432d4ca9327fa
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 26, 2021
@miketaylr @chromium-wpt-export-bot
Update Sec-CH-UA tests: fix existing tests, and test brand size.
d5ba3be 
As of WICG/ua-client-hints#179,
https://wicg.github.io/ua-client-hints/#user-agent-brand now requires
that a brand in a brand list not be longer than 32 bytes.

This CL adds a new test for the userAgentData.brands interface, and
modifies the existing sec-ch-ua HTTP tests.

Also, the existing sec-ch-ua HTTP tests were updated to more closely
reflect the current state of UA-CH ("UA" is not a valid token, and
"Accept-CH-Lifetime" is not shipping).

Bug: 1263180
Change-Id: Ifa7cbf18d67271e2dd1dc1d485f432d4ca9327fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3243544
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Auto-Submit: Mike Taylor <miketaylr@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935138}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 26, 2021
@miketaylr @chromium-wpt-export-bot
Update Sec-CH-UA tests: fix existing tests, and test brand size.
c1be1a0 
As of WICG/ua-client-hints#179,
https://wicg.github.io/ua-client-hints/#user-agent-brand now requires
that a brand in a brand list not be longer than 32 bytes.

This CL adds a new test for the userAgentData.brands interface, and
modifies the existing sec-ch-ua HTTP tests.

Also, the existing sec-ch-ua HTTP tests were updated to more closely
reflect the current state of UA-CH ("UA" is not a valid token, and
"Accept-CH-Lifetime" is not shipping).

Bug: 1263180
Change-Id: Ifa7cbf18d67271e2dd1dc1d485f432d4ca9327fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3243544
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Auto-Submit: Mike Taylor <miketaylr@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935138}
FrankEnderman pushed a commit to FrankEnderman/cursemium that referenced this issue Oct 27, 2021
@miketaylr
Update Sec-CH-UA tests: fix existing tests, and test brand size.
ca7ab45 
As of WICG/ua-client-hints#179,
https://wicg.github.io/ua-client-hints/#user-agent-brand now requires
that a brand in a brand list not be longer than 32 bytes.

This CL adds a new test for the userAgentData.brands interface, and
modifies the existing sec-ch-ua HTTP tests.

Also, the existing sec-ch-ua HTTP tests were updated to more closely
reflect the current state of UA-CH ("UA" is not a valid token, and
"Accept-CH-Lifetime" is not shipping).

Bug: 1263180
Change-Id: Ifa7cbf18d67271e2dd1dc1d485f432d4ca9327fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3243544
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Auto-Submit: Mike Taylor <miketaylr@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935138}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 29, 2021
@miketaylr @moz-wptsync-bot
Bug 1737699 [wpt PR 31381] - Update Sec-CH-UA tests: fix existing tes…
59a9f7f 
…ts, and test brand size., a=testonly

Automatic update from web-platform-tests
Update Sec-CH-UA tests: fix existing tests, and test brand size.

As of WICG/ua-client-hints#179,
https://wicg.github.io/ua-client-hints/#user-agent-brand now requires
that a brand in a brand list not be longer than 32 bytes.

This CL adds a new test for the userAgentData.brands interface, and
modifies the existing sec-ch-ua HTTP tests.

Also, the existing sec-ch-ua HTTP tests were updated to more closely
reflect the current state of UA-CH ("UA" is not a valid token, and
"Accept-CH-Lifetime" is not shipping).

Bug: 1263180
Change-Id: Ifa7cbf18d67271e2dd1dc1d485f432d4ca9327fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3243544
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Auto-Submit: Mike Taylor <miketaylr@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935138}

--

wpt-commits: c1be1a0eea9b45e6aa3ee088f76aee7955092693
wpt-pr: 31381
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Nov 1, 2021
@miketaylr @moz-wptsync-bot
Bug 1737699 [wpt PR 31381] - Update Sec-CH-UA tests: fix existing tes…
b5c2e7e 
…ts, and test brand size., a=testonly

Automatic update from web-platform-tests
Update Sec-CH-UA tests: fix existing tests, and test brand size.

As of WICG/ua-client-hints#179,
https://wicg.github.io/ua-client-hints/#user-agent-brand now requires
that a brand in a brand list not be longer than 32 bytes.

This CL adds a new test for the userAgentData.brands interface, and
modifies the existing sec-ch-ua HTTP tests.

Also, the existing sec-ch-ua HTTP tests were updated to more closely
reflect the current state of UA-CH ("UA" is not a valid token, and
"Accept-CH-Lifetime" is not shipping).

Bug: 1263180
Change-Id: Ifa7cbf18d67271e2dd1dc1d485f432d4ca9327fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3243544
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Auto-Submit: Mike Taylor <miketaylr@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935138}

--

wpt-commits: c1be1a0eea9b45e6aa3ee088f76aee7955092693
wpt-pr: 31381
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this issue Nov 18, 2021
@miketaylr @Gabisampaio
Update Sec-CH-UA tests: fix existing tests, and test brand size.
eda4940 
As of WICG/ua-client-hints#179,
https://wicg.github.io/ua-client-hints/#user-agent-brand now requires
that a brand in a brand list not be longer than 32 bytes.

This CL adds a new test for the userAgentData.brands interface, and
modifies the existing sec-ch-ua HTTP tests.

Also, the existing sec-ch-ua HTTP tests were updated to more closely
reflect the current state of UA-CH ("UA" is not a valid token, and
"Accept-CH-Lifetime" is not shipping).

Bug: 1263180
Change-Id: Ifa7cbf18d67271e2dd1dc1d485f432d4ca9327fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3243544
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Auto-Submit: Mike Taylor <miketaylr@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935138}
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
@miketaylr
Update Sec-CH-UA tests: fix existing tests, and test brand size.
cf4d293 
As of WICG/ua-client-hints#179,
https://wicg.github.io/ua-client-hints/#user-agent-brand now requires
that a brand in a brand list not be longer than 32 bytes.

This CL adds a new test for the userAgentData.brands interface, and
modifies the existing sec-ch-ua HTTP tests.

Also, the existing sec-ch-ua HTTP tests were updated to more closely
reflect the current state of UA-CH ("UA" is not a valid token, and
"Accept-CH-Lifetime" is not shipping).

Bug: 1263180
Change-Id: Ifa7cbf18d67271e2dd1dc1d485f432d4ca9327fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3243544
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Auto-Submit: Mike Taylor <miketaylr@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935138}
NOKEYCHECK=True
GitOrigin-RevId: ca7ab45b02b584a9da8f4a3fedc8ca3a29fae5b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @jwrosewell