Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of dictionaries instead of interfaces #22

Closed
beaufortfrancois opened this issue Jul 24, 2020 · 2 comments · Fixed by #30
Closed

Use of dictionaries instead of interfaces #22

beaufortfrancois opened this issue Jul 24, 2020 · 2 comments · Fixed by #30

Comments

@beaufortfrancois
Copy link
Contributor

beaufortfrancois commented Jul 24, 2020 •
edited

As raised in a blink-dev discussion, it would be better to prefer dictionaries over interfaces for easier logging purposes.

I could see the interfaces below replaced by dictionaries, as they don't have methods on them:

  • HIDCollectionInfo
  • HIDReportInfo
  • HIDReportItem

For info, this is what web developers get today:

JSON.stringify(myHidDevice.collections);
>> "[{}]"
@beaufortfrancois
Copy link
Contributor Author

@nondebug What do you think?
I'm willing to submit a spec PR and Chromium CL if that helps ;)

@beaufortfrancois beaufortfrancois mentioned this issue Sep 9, 2020
Merged
@beaufortfrancois
Copy link
Contributor Author

Spec PR: #30
Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/2398541

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 30, 2020
@beaufortfrancois @chromium-wpt-export-bot
[WebHID] Change some interfaces to dictionaries
39fa334 
This CL changes HIDCollectionInfo, HIDReportInfo, and HIDReportItem
interfaces to dictionaries for easier logging with JSON and to avoid
polluting the window web namespace.

Spec: WICG/webhid#22
Test: https://webhid-collections.glitch.me/

Change-Id: Ife8d089505312bba9f42e5d8fb1c466f44bd8e45
Bug: 890096
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 30, 2020
@beaufortfrancois @chromium-wpt-export-bot
[WebHID] Change some interfaces to dictionaries
672fa18 
This CL changes HIDCollectionInfo, HIDReportInfo, and HIDReportItem
interfaces to dictionaries for easier logging with JSON and to avoid
polluting the window web namespace.

Spec: WICG/webhid#22
Test: https://webhid-collections.glitch.me/

Change-Id: Ife8d089505312bba9f42e5d8fb1c466f44bd8e45
Bug: 890096
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 1, 2020
@beaufortfrancois @chromium-wpt-export-bot
[WebHID] Change some interfaces to dictionaries
f21ec9c 
This CL changes HIDCollectionInfo, HIDReportInfo, and HIDReportItem
interfaces to dictionaries for easier logging with JSON and to avoid
polluting the window web namespace.

Spec: WICG/webhid#22
Test: https://webhid-collections.glitch.me/

Change-Id: Ife8d089505312bba9f42e5d8fb1c466f44bd8e45
Bug: 890096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398541
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#812626}
pull bot pushed a commit to Alan-love/chromium that referenced this issue Oct 1, 2020
@beaufortfrancois
[WebHID] Change some interfaces to dictionaries
0511c9e 
This CL changes HIDCollectionInfo, HIDReportInfo, and HIDReportItem
interfaces to dictionaries for easier logging with JSON and to avoid
polluting the window web namespace.

Spec: WICG/webhid#22
Test: https://webhid-collections.glitch.me/

Change-Id: Ife8d089505312bba9f42e5d8fb1c466f44bd8e45
Bug: 890096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398541
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#812626}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 1, 2020
@beaufortfrancois @chromium-wpt-export-bot
[WebHID] Change some interfaces to dictionaries
af37227 
This CL changes HIDCollectionInfo, HIDReportInfo, and HIDReportItem
interfaces to dictionaries for easier logging with JSON and to avoid
polluting the window web namespace.

Spec: WICG/webhid#22
Test: https://webhid-collections.glitch.me/

Change-Id: Ife8d089505312bba9f42e5d8fb1c466f44bd8e45
Bug: 890096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398541
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#812626}
ziransun pushed a commit to ziransun/wpt that referenced this issue Oct 6, 2020
@beaufortfrancois @ziransun
[WebHID] Change some interfaces to dictionaries
9388db6 
This CL changes HIDCollectionInfo, HIDReportInfo, and HIDReportItem
interfaces to dictionaries for easier logging with JSON and to avoid
polluting the window web namespace.

Spec: WICG/webhid#22
Test: https://webhid-collections.glitch.me/

Change-Id: Ife8d089505312bba9f42e5d8fb1c466f44bd8e45
Bug: 890096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398541
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#812626}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 8, 2020
@beaufortfrancois @moz-wptsync-bot
Bug 1668173 [wpt PR 25863] - [WebHID] Change some interfaces to dicti…
9ee3bc5 
…onaries, a=testonly

Automatic update from web-platform-tests
[WebHID] Change some interfaces to dictionaries

This CL changes HIDCollectionInfo, HIDReportInfo, and HIDReportItem
interfaces to dictionaries for easier logging with JSON and to avoid
polluting the window web namespace.

Spec: WICG/webhid#22
Test: https://webhid-collections.glitch.me/

Change-Id: Ife8d089505312bba9f42e5d8fb1c466f44bd8e45
Bug: 890096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398541
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#812626}

--

wpt-commits: af372277727018e5f88f8a5e1f1db5069582ad8f
wpt-pr: 25863
sidvishnoi pushed a commit to sidvishnoi/gecko-webmonetization that referenced this issue Oct 13, 2020
@beaufortfrancois @moz-wptsync-bot
Bug 1668173 [wpt PR 25863] - [WebHID] Change some interfaces to dicti…
87036d1 
…onaries, a=testonly

Automatic update from web-platform-tests
[WebHID] Change some interfaces to dictionaries

This CL changes HIDCollectionInfo, HIDReportInfo, and HIDReportItem
interfaces to dictionaries for easier logging with JSON and to avoid
polluting the window web namespace.

Spec: WICG/webhid#22
Test: https://webhid-collections.glitch.me/

Change-Id: Ife8d089505312bba9f42e5d8fb1c466f44bd8e45
Bug: 890096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398541
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#812626}

--

wpt-commits: af372277727018e5f88f8a5e1f1db5069582ad8f
wpt-pr: 25863
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
@beaufortfrancois
[WebHID] Change some interfaces to dictionaries
5aab588 
This CL changes HIDCollectionInfo, HIDReportInfo, and HIDReportItem
interfaces to dictionaries for easier logging with JSON and to avoid
polluting the window web namespace.

Spec: WICG/webhid#22
Test: https://webhid-collections.glitch.me/

Change-Id: Ife8d089505312bba9f42e5d8fb1c466f44bd8e45
Bug: 890096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398541
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#812626}
GitOrigin-RevId: 0511c9e8fceecd5fc76b986fe37c2bc00c318d33
ns-rsilva pushed a commit to ns-rsilva/chromium that referenced this issue Apr 25, 2024
@beaufortfrancois
[WebHID] Change some interfaces to dictionaries
67d205e 
This CL changes HIDCollectionInfo, HIDReportInfo, and HIDReportItem
interfaces to dictionaries for easier logging with JSON and to avoid
polluting the window web namespace.

Spec: WICG/webhid#22
Test: https://webhid-collections.glitch.me/

Change-Id: Ife8d089505312bba9f42e5d8fb1c466f44bd8e45
Bug: 890096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398541
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#812626}

Former-commit-id: 0511c9e8fceecd5fc76b986fe37c2bc00c318d33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change some interfaces to dictionaries & Clean beaufortfrancois/webhid
1 participant
@beaufortfrancois