Signature attributes should always be freshly generated and never read from the stack #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also led into removing some unnecessary tests. I will also make another PR where I refactor the code a little and I will add a test which will ensure that this kind of situation would not reoccur. However it's still WIP and I still need to work on it a bit more on Monday. Current status here, but I will still write more thorough tests there: https://github.com/WICG/webpackage/compare/main...sonkkeli:webpackage:generate-real-ed25519-keys-in-tests?expand=1 |
sonkkeli
force-pushed
the
fix-signature-attribute-generation
branch
from
1145c6b
to
0f125ef
Compare
github-actions bot
added a commit
that referenced
this pull request
Oct 28, 2022
SHA: ca2595e Reason: push, by sonkkeli Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 28, 2022
SHA: ca2595e Reason: push, by sonkkeli Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug which I had on generating the payload for signing in case there would already be existing signatures on the signature stack.