WebBundleId class to calculate it from private/public key #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonkkeli
force-pushed
the
calculate-app-id
branch
2 times, most recently
from
d8f8230
to
ed99189
Compare
sonkkeli
force-pushed
the
calculate-app-id
branch
6 times, most recently
from
0e3bcd8
to
dc1d539
Compare
irori
reviewed
Nov 21, 2022
sonkkeli
force-pushed
the
calculate-app-id
branch
from
dc1d539
to
605cbb0
Compare
|
PTAL :) |
irori
approved these changes
Nov 22, 2022
sonkkeli
force-pushed
the
calculate-app-id
branch
from
605cbb0
to
d84a57a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also had to move getting the raw public key outside of the IntegrityBlockSigner class.