Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add override headers support to the CLI tool #850

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

sonkkeli
Copy link
Collaborator

No description provided.

@sonkkeli sonkkeli requested a review from cmfcmf March 23, 2023 12:51
@sonkkeli sonkkeli force-pushed the add-header-overrides-cli-v2 branch from cffc4c5 to af8953e Compare March 23, 2023 12:59
js/bundle/src/encoder.ts Outdated Show resolved Hide resolved
js/bundle/src/encoder.ts Outdated Show resolved Hide resolved
js/bundle/src/encoder.ts Outdated Show resolved Hide resolved
js/bundle/src/cli.ts Outdated Show resolved Hide resolved
js/bundle/src/cli.ts Outdated Show resolved Hide resolved
js/bundle/tests/testdata/header-overrides.json Outdated Show resolved Hide resolved
@sonkkeli
Copy link
Collaborator Author

PTAL :)

@sonkkeli sonkkeli force-pushed the add-header-overrides-cli-v2 branch from 5cefebd to cd64da6 Compare March 23, 2023 15:01
@sonkkeli sonkkeli force-pushed the add-header-overrides-cli-v2 branch from cd64da6 to 0b512fa Compare March 23, 2023 15:03
Copy link
Collaborator

@cmfcmf cmfcmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % one last comment

js/bundle/src/cli.ts Outdated Show resolved Hide resolved
@sonkkeli sonkkeli merged commit 5e19ab7 into WICG:main Mar 23, 2023
@sonkkeli sonkkeli deleted the add-header-overrides-cli-v2 branch March 23, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants