Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cborEncodeSignatureAttributesMap SignatureAttributesMap func #858

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Replace cborEncodeSignatureAttributesMap SignatureAttributesMap func #858

merged 1 commit into from
Apr 21, 2023

Conversation

sonkkeli
Copy link
Collaborator

No description provided.

@sonkkeli sonkkeli requested a review from cmfcmf April 21, 2023 13:25
@sonkkeli sonkkeli changed the title Replace cborEncodeSignatureAttributesMap with method of SignatureAttributesMap Replace cborEncodeSignatureAttributesMap SignatureAttributesMap func Apr 21, 2023
cmfcmf
cmfcmf approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@cmfcmf cmfcmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonkkeli sonkkeli merged commit 711307e into WICG:main Apr 21, 2023
7 checks passed
@sonkkeli sonkkeli deleted the signature-attributes-cbor branch April 21, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmfcmf cmfcmf cmfcmf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sonkkeli @cmfcmf