Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for python3 #12

Closed
wants to merge 1 commit into from
Closed

Conversation

nsorros
Copy link

@nsorros nsorros commented Dec 14, 2018

This PR aims to make the code compatible with Python3 when running with an input file.

There were two problems that needed fixing

  • cPickle which has been replaced with pickle
  • print statement in loaders

@kylase
Copy link

kylase commented Dec 16, 2018

Thanks for the submitting the PR. However, I am holding onto a PR that is Python 3 compatible (#11), which has the same changes you made. Therefore, I won't be merging your changes.

@hblanks
Copy link

hblanks commented Dec 17, 2018

@kylase - thanks for the review! But we'd love to get Python 3 support in, as otherwise we're obliged to maintain our own fork of the project.

Could @nsorros or I either help you get PR #11 merged, or help you split it into one change for Python 3 compatibility, and one for the training fix?

@kylase
Copy link

kylase commented Dec 17, 2018

@hblanks Thanks for the offer!
I am working on #11 this week and should be able to merge it by end of this week. 🤞

@knmnyn
Copy link
Member

knmnyn commented Dec 17, 2018

Thank you all for your continued support of Neural ParsCit! @kylase is our key developer at this point and is looking at scalability issues, just FYI.

@kylase
Copy link

kylase commented Dec 21, 2018

@nsorros and @hblanks I have released a patch that incorporated minor Python 3 compatibility. You can try it out and let me know if there are issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants