-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restoring Docs PR after Github closed it #261
Conversation
git-subtree-dir: ROSCO git-subtree-split: 99c9f872d9590671be6be1a716ac293467b49e53
7fa1ae25e Don't check ZMQ period if no ZMQ_Mode 45aad140c Add more error checking in checkpoint file I/O c5de22f59 Modernize setup and CI (#297) REVERT: 99c9f872d Merge remote-tracking branch 'upstream/v2.9.0' into v2.9.0 REVERT: c29fc8597 Fix checkpoint testing paths REVERT: 75c3d2988 F_NumNotchFilts is not allowed to have a default value REVERT: ba0bc45d0 Update rosco dylib dir REVERT: 207d3f73e Add Ext_Interface flag git-subtree-dir: ROSCO git-subtree-split: 7fa1ae25e6b3866c353d5976e7ac68f597bf73af
6c2807a9e Merge remote-tracking branch 'upstream/develop' into v2.9.0_prep 4cdef25d4 Merge pull request #300 from NREL/smart_lib_path b1c943ea0 fixes for windows 8c39105a3 hopefully caught everything 2d0525830 switch to cmake-build-extension and logic for finding rosco library path git-subtree-dir: ROSCO git-subtree-split: 6c2807a9ece26b4b94bc0a78bc4ca8388fba60b0
@dzalkind - Seems like this is ready to go? |
Yes, it can be ready to go, but there is always more to document. How about I work on it until Wednesday COB, and then we merge? |
@ptrbortolotti, I'm not as familiar with examples 05, 07, and 08 as you are. I added placeholder READMEs. Do you want to expand or save for later? Also, should we pull |
@AthulKrishnaSundarrajan, I added a placeholder README in example 14_level2ccd. Do you want to add anything there while we're here? Should anything in |
Readme for 13_DTQP looks good. For 14_level2ccd, I'll work on the readme and a tutorial on how to use LPV models and DTQPy |
my apologies for the delays @dzalkind ! I should have now addressed your (good) comments |
* update docs and add notebooks * remove R history
Only the Windows CI tests are failing, which we can address in a future PR. |
Purpose
Clean up and revise the example inputs and documentation.
examples/00_setup/get_wisdem_yamls.py
to pull relevant geometry inputs from WISDEManalysis_options.yaml
input.l_fill
to RAFT, where density was not properly set.Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
x
in the boxes that apply.