Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error if an unknow HTTP method is used #117

Merged
merged 2 commits into from Mar 22, 2016
Merged

Throw error if an unknow HTTP method is used #117

merged 2 commits into from Mar 22, 2016

Conversation

nabsul
Copy link
Contributor

@nabsul nabsul commented Jan 5, 2016

No description provided.

@rmccue
Copy link
Member

rmccue commented Jan 11, 2016

Thanks for the patch! Can you change the error prefix from json_ to rest_, and add the text domain (rest_oauth1) to the translation (so it reads __( 'Unknown http method: %s', 'rest_oauth1' )) please? :)

@nabsul
- Add text domain to translation
fcde078 
- Use correct previx to error code
@nabsul
Copy link
Contributor Author

nabsul commented Jan 21, 2016

ping @rmccue
(I'd like to finally delete this repo branch from my account 😄 )

rachelbaker added a commit that referenced this pull request Mar 22, 2016
@rachelbaker
Merge pull request #117 from nabsul/master
cda09b8 
Throw error if an unknow HTTP method is used
@rachelbaker rachelbaker merged commit cda09b8 into WP-API:master Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nabsul @rmccue @rachelbaker