Merge pull request #1253 from WP-API/1224-return-user

Return full user object when deleting user

lib/endpoints/class-wp-rest-users-controller.php

@@ -312,13 +312,17 @@ public function delete_item( $request ) {
 			}
 		}
 
+		$get_request = new WP_REST_Request( 'GET', rest_url( 'wp/v2/users/' . $id ) );
+		$get_request->set_param( 'context', 'edit' );
+		$orig_user = $this->prepare_item_for_response( $user, $get_request );
+
 		$result = wp_delete_user( $id, $reassign );
 
 		if ( ! $result ) {
 			return new WP_Error( 'rest_cannot_delete', __( 'The user cannot be deleted.' ), array( 'status' => 500 ) );
-		} else {
-			return array( 'message' => __( 'Deleted user' ) );
 		}
+
+		return $orig_user;
 	}
 
 	/**

tests/test-rest-users-controller.php

@@ -597,17 +597,20 @@ public function test_update_user_invalid_id() {
 	}
 
 	public function test_delete_item() {
-		$user_id = $this->factory->user->create();
+		$user_id = $this->factory->user->create( array( 'display_name' => 'Deleted User' ) );
 
 		$this->allow_user_to_manage_multisite();
 		wp_set_current_user( $this->user );
 
+		$userdata = get_userdata( $user_id ); // cache for later
 		$request = new WP_REST_Request( 'DELETE', sprintf( '/wp/v2/users/%d', $user_id ) );
 		$response = $this->server->dispatch( $request );
 
 		$this->assertNotInstanceOf( 'WP_Error', $response );
 		$response = rest_ensure_response( $response );
 		$this->assertEquals( 200, $response->get_status() );
+		$data = $response->get_data();
+		$this->assertEquals( 'Deleted User', $data['name'] );
 	}
 
 	public function test_delete_user_without_permission() {