This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Return full user object when deleting user #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let the client more easily restore the data, should they need to
|
@WP-API/amigos #reviewmerge |
| @@ -312,12 +312,16 @@ public function delete_item( $request ) { | |||
| } | |||
| } | |||
|
|
|||
| $mock_request = new WP_REST_Request( 'GET', '/wp/users/' . $id ); | |||
There was a problem hiding this comment.
Hmm, this should fail?
There was a problem hiding this comment.
Oh. Because it's not routing through the server, the request can be whatever. I guess ultimately it should route through the server, so it's not hard-coupled to this controller.
added 2 commits
May 19, 2015 13:21
added 2 commits
May 20, 2015 16:17
danielbachhuber
pushed a commit
that referenced
this pull request
May 21, 2015
Return full user object when deleting user
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let the client more easily restore the data, should they need
to
See #1224