This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Add support for passing the role parameter to insert_user() method. #335 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. Does this allow privilege escalation? If I have the ability to add new users, should I have the ability to give them any role I want? cc @nacin |
|
If you can create users, there's no way to limit which roles you can assign |
|
Cool, works for me. |
rmccue
added a commit
that referenced
this pull request
Aug 29, 2014
Add support for passing the role parameter to insert_user() method. #335
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for passing the role parameter to insert_user() method.
This allows users to be created and/or updated with a specific role.
Fixes #335