Skip to content
This repository has been archived by the owner on Sep 24, 2018. It is now read-only.

Link taxonomies to their associated collections #1817

Merged
merged 2 commits into from Dec 9, 2015

Conversation

danielbachhuber
Copy link
Member

Changes $data from an array to WP_REST_Response when
supplied to rest_prepare_taxonomy

Fixes #1381

Changes `$data` from an array to WP_REST_Response when
supplied to `rest_prepare_taxonomy`
@danielbachhuber danielbachhuber added this to the 2.0 Beta 9 milestone Dec 9, 2015
@danielbachhuber
Copy link
Member Author

@WP-API/amigos #reviewmerge

@danielbachhuber
Copy link
Member Author

local ➜  ~  http GET http://wordpress-develop.dev/wp-json/wp/v2/taxonomies/category --body
{
    "_links": {
        "collection": [
            {
                "href": "http://wordpress-develop.dev/wp-json/wp/v2/categories"
            }
        ]
    },
    "description": "",
    "hierarchical": true,
    "labels": {
        "add_new_item": "Add New Category",
        "add_or_remove_items": null,
        "all_items": "All Categories",
        "choose_from_most_used": null,
        "edit_item": "Edit Category",
        "items_list": "Categories list",
        "items_list_navigation": "Categories list navigation",
        "menu_name": "Categories",
        "name": "Categories",
        "name_admin_bar": "category",
        "new_item_name": "New Category Name",
        "no_terms": "No categories",
        "not_found": "No categories found.",
        "parent_item": "Parent Category",
        "parent_item_colon": "Parent Category:",
        "popular_items": null,
        "search_items": "Search Categories",
        "separate_items_with_commas": null,
        "singular_name": "Category",
        "update_item": "Update Category",
        "view_item": "View Category"
    },
    "name": "Categories",
    "show_cloud": true,
    "slug": "category",
    "types": [
        "post"
    ]
}

'collection' => array(
'href' => rest_url( sprintf( 'wp/v2/%s', $base ) ),
),
) );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing parens are a level off here.

@rmccue
Copy link
Member

rmccue commented Dec 9, 2015

Looks good apart from minor coding standard tweak.

danielbachhuber added a commit that referenced this pull request Dec 9, 2015
Link taxonomies to their associated collections
@danielbachhuber danielbachhuber merged commit 234e3db into develop Dec 9, 2015
@danielbachhuber danielbachhuber deleted the 1381-link-taxonomy-collections branch December 9, 2015 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants