This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Call prepare_item_for_response() directly in Comment::create_item()
#2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us pass the original request through to `prepare_item_for_response()`, giving it genuine context, and avoids an unnecessary call to `get_item()`
|
@joehoyle how do you feel about this pattern? Creating a new |
|
Yeah I'm +1 for this, seems more lightweight and I don't see anything important skipped. |
danielbachhuber
added a commit
that referenced
this pull request
Jan 14, 2016
Call `prepare_item_for_response()` directly in `Comment::create_item()`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us pass the original request through to
prepare_item_for_response(), giving it genuine context, and avoids anunnecessary call to
get_item()