This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Dates for new or updated posts should honor date parameters passed #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rmccue #reviewmerge |
|
Good catch, 👍 |
rmccue
added a commit
that referenced
this pull request
May 25, 2014
Dates for new or updated posts should honor date parameters passed
kellbot
pushed a commit
to kellbot/WP-API
that referenced
this pull request
Aug 1, 2014
kellbot
pushed a commit
to kellbot/WP-API
that referenced
this pull request
Aug 1, 2014
Dates for new or updated posts should honor date parameters passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the logic of WP_JSON_Posts->insert_post() where even if the
$data['date'],$data['date_gmt'],$data['modified'], or$data['modified_gmt']are not empty the values are populated with the current time in GMT.This appears to be a blocker for the 1.0 release, if this bug is confirmed by @rmccue.
See current logic here: https://github.com/WP-API/WP-API/blob/master/lib/class-wp-json-posts.php#L1185