This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WordPress Trunk is in /srv/www/wordpress-trunk.dev but the test suite is somewhere else.
Conflicts: lib/class-wp-json-posts.php
Fixed up, and includes #251 |
@@ -3,6 +3,7 @@ | |||
<!-- Default test suite to run all tests --> | |||
<testsuite> | |||
<directory prefix="test_" suffix=".php">tests</directory> | |||
<directory prefix="test-" suffix=".php">tests</directory> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the file naming consistent please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WordPress core uses dashes, not underscores, for filenames.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but I'd rather change them all at once (in a separate issue) than be inconsistent.
Includes changes from #274 mixed in. |
Merged
Fixed in #279. |
Japh
pushed a commit
to Japh/WP-API
that referenced
this pull request
Sep 29, 2014
Fixes WP-API#275 for now. git-svn-id: http://gsoc.svn.wordpress.org/2013/rmccue/trunk@2351 f69abe3c-2ee2-4550-9a6d-17bd458115be
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And throw an error if user doesn't have access to a post's revisions #251