New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP_JSON_Posts new_post method should be renamed to create_post #374

Merged
merged 3 commits into from Jul 27, 2014

Conversation

Projects
None yet
2 participants
@rachelbaker
Member

rachelbaker commented Jul 27, 2014

title says it all

@rmccue rmccue added this to the 1.2 milestone Jul 27, 2014

@rmccue rmccue self-assigned this Jul 27, 2014

rmccue added a commit that referenced this pull request Jul 27, 2014

Merge pull request #374 from WP-API/issue-374
WP_JSON_Posts new_post method should be renamed to create_post

@rmccue rmccue merged commit cadbcd5 into master Jul 27, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Jul 27, 2014

Member

I think we may need this for users/etc as well.

Member

rmccue commented Jul 27, 2014

I think we may need this for users/etc as well.

@rmccue rmccue deleted the issue-374 branch Jul 27, 2014

@rachelbaker

This comment has been minimized.

Show comment
Hide comment
@rachelbaker

rachelbaker Jul 27, 2014

Member

Created issue for Users in #376

Member

rachelbaker commented Jul 27, 2014

Created issue for Users in #376

$response = json_ensure_response( $response );
$this->check_create_response( $response );
$response_data = $response->get_data();
- $new_post = get_post( $response_data['ID'] );
- $this->assertEquals( $data['author']->ID, $new_post->post_author );
+ $create_post = get_post( $response_data['ID'] );

This comment has been minimized.

@rmccue

rmccue Jul 27, 2014

Member

Totally missed this, but this doesn't really make sense.

@rmccue

rmccue Jul 27, 2014

Member

Totally missed this, but this doesn't really make sense.

kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014

Merge pull request #374 from WP-API/issue-374
WP_JSON_Posts new_post method should be renamed to create_post
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment