This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
WP_JSON_Posts new_post method should be renamed to create_post #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccue
added a commit
that referenced
this pull request
Jul 27, 2014
WP_JSON_Posts new_post method should be renamed to create_post
|
I think we may need this for users/etc as well. |
|
Created issue for Users in #376 |
| $response = json_ensure_response( $response ); | ||
| $this->check_create_response( $response ); | ||
|
|
||
| $response_data = $response->get_data(); | ||
| $new_post = get_post( $response_data['ID'] ); | ||
| $this->assertEquals( $data['author']->ID, $new_post->post_author ); | ||
| $create_post = get_post( $response_data['ID'] ); |
There was a problem hiding this comment.
Totally missed this, but this doesn't really make sense.
kellbot
pushed a commit
to kellbot/WP-API
that referenced
this pull request
Aug 1, 2014
WP_JSON_Posts new_post method should be renamed to create_post
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title says it all