Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

Make buttons visible only if {{AFC submission}} is detected #69

Closed
wikipedia-mabdul opened this issue Jul 27, 2013 · 13 comments
Closed

Comments

@wikipedia-mabdul
Copy link
Member

make the accept, decline, mark/unmark buttons visible depending on the fact if there is {{AFC submission||}} available. (search for "aborting" in the code to understand what I mean)

@theopolisme
Copy link
Contributor

What should be shown if there isn't an {{AFC submission}} on the page? Seems to me like the current behavior is correct...

@wikipedia-mabdul
Copy link
Member Author

you missed something:

Possibility 1:
{{AFC submission|| ... }} is available - then display everything (accept, decline, mark, etc.)

Possibility 2:
{{AFC submission|r| ... }} is available - then display everything (accept, decline, unmark, etc.)

Possibility 3:
{{AFC submission|d| ... }} is available - then display comment, clean up

Possibility 4:
no template at all - then display clean up, submit (not in the script/ developed at the moment)

@theopolisme
Copy link
Contributor

Oh, alright, now you're making sense ;)
I'm doing the submit button stuff as we type, by the way.

@theopolisme
Copy link
Contributor

Submit is done, and will only appear if the page isn't currently pending or in review. The same idea can be applied to your above logic. I'll work on this tonight if you aren't already.

@wikipedia-mabdul
Copy link
Member Author

feel free - I will work on some TODOs and on another issue (formatgeneral - I found a solution I believe!)

@Technical-13
Copy link
Contributor

@theopolisme @wikipedia-mabdul You both missed something actually....

you missed something:

Possibility 1:
{{AFC submission|| ... }} is available - then display everything (accept, decline, mark, etc.)

Possibility 2:
{{AFC submission|r| ... }} is available - then display everything (accept, decline, unmark, etc.)

Possibility 3:
{{AFC submission|d| ... }} is available - then display comment, clean up

Possibility 4:
no template at all - then display clean up, mark as draft, submit (not in the script/ developed at the moment)

Possibility 5:
{{AFC submission|t| ... }} is available - then display comment, clean up, submit

@ghost ghost assigned theopolisme Jul 28, 2013
@theopolisme
Copy link
Contributor

@Technical-13 by "mark as draft" do you mean "add {{subst:AFC draft|username}}"?

Also: does "clean up" still need to be hidden away in a menu for possibilities 3,4,5?

@wikipedia-mabdul
Copy link
Member Author

no, cleanup should be available at any times - maybe hide it if the submission is already cleaned. Code is more or less already in - see
else if(action === 'cleanup') (or so)

@theopolisme
Copy link
Contributor

Cool, implementing now

theopolisme added a commit that referenced this issue Jul 28, 2013
@theopolisme
Copy link
Contributor

Everything i've done so far has been tested @ [[Wikipedia_talk:Articles_for_creation/sandbox]]; going to work on adding "mark as draft" button after lunch.

@Technical-13
Copy link
Contributor

I think in the "Other Stuff" section that currently only does "Cleanup" there should be a second option that detects if there is currently a declined template and if the draft hasn't be edited in six months there should be a second button to "tag for G13".

@theopolisme
Copy link
Contributor

^^ Branching off into a separate issue

@Nathan2055
Copy link
Member

@Technical-13 - Moved to #73.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants