Catch some undefined indexes in the Largo Recent Posts widget.

Part of #1492
WPBuddy · Dec 18, 2018 · a8caa13 · a8caa13
1 parent 19d66e5
commit a8caa13
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/inc/widgets/largo-recent-posts.php b/inc/widgets/largo-recent-posts.php
@@ -54,17 +54,23 @@ function widget( $args, $instance ) {
 
 		$query_args = array (
 			'post__not_in' 	 => get_option( 'sticky_posts' ),
-			'posts_per_page' => $instance['num_posts'],
+			'posts_per_page' => isset( $instance['num_posts'] ) ? $instance['num_posts'] : 3,
 			'post_status'	=> 'publish'
 		);
 
 		if ( isset( $instance['avoid_duplicates'] ) && $instance['avoid_duplicates'] === 1 ) {
 			$query_args['post__not_in'] = $shown_ids;
 		}
-		if ( $instance['cat'] != '' ) $query_args['cat'] = $instance['cat'];
-		if ( $instance['tag'] != '') $query_args['tag'] = $instance['tag'];
-		if ( $instance['author'] != '') $query_args['author'] = $instance['author'];
-		if ( $instance['taxonomy'] != '') {
+		if ( ! empty( $instance['cat'] ) ) {
+			$query_args['cat'] = $instance['cat'];
+		}
+		if ( ! empty( $instance['tag'] ) ) {
+			$query_args['tag'] = $instance['tag'];
+		}
+		if ( ! empty( $instance['author'] ) ) {
+			$query_args['author'] = $instance['author'];
+		}
+		if ( ! empty( $instance['taxonomy'] ) && ! empty( $instance['term'] ) ) {
 			$query_args['tax_query'] = array(
 				array(
 					'taxonomy'	=> $instance['taxonomy'],
@@ -112,7 +118,7 @@ function widget( $args, $instance ) {
 		// close the ul
 		echo '</ul>';
 
-		if( $instance['linkurl'] !='' ) {
+		if( ! empty( $instance['linkurl'] ) ) {
 			echo '<p class="morelink"><a href="' . esc_url( $instance['linkurl'] ) . '">' . esc_html( $instance['linktext'] ) . '</a></p>';
 		}
 		echo $args['after_widget'];