Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all custom Largo author meta fields in Co-Authors #1097

Closed
benlk opened this issue Jan 25, 2016 · 4 comments
Closed

Support all custom Largo author meta fields in Co-Authors #1097

benlk opened this issue Jan 25, 2016 · 4 comments
Assignees

Comments

@benlk
Copy link
Collaborator

benlk commented Jan 25, 2016

Our Co-Authors settings filter: https://github.com/INN/Largo/blob/master/inc/users.php#L50

Add:

  • job title
  • hide email
  • hide in staff roster (if coauthors get sucked into the staff roster widget, that is?)

This will be a hotfix against Master.

@benlk benlk added this to the 0.5.5 - Story Elements milestone Jan 25, 2016
@aschweigert
Copy link

job title? I think hide email is worth having, hide in staff roster is less important because guest authors don't (presently) appear in the staff roster so there would be more work involved in making it support those (add that role to the list of roles supported by the shortcode, etc.)

@benlk
Copy link
Collaborator Author

benlk commented Jan 25, 2016

Job title because of http://jira.inn.org/browse/WE-72, to match its being an option for normal users in Largo: https://github.com/INN/Largo/blob/master/inc/users.php#L260-L266

If the staff roster doesn't include coauthors then there isn't a reason to add the option here and now, so I shan't. Do we want to support that in the future?

@aschweigert
Copy link

sorry, your original description just said "job" but the field should be called "job title" consistently in both places

@benlk
Copy link
Collaborator Author

benlk commented Jan 26, 2016

Oh, sorry the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants