Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job title to fields accepted by coauthors #1098

Merged
merged 10 commits into from
Jan 26, 2016
Merged

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Jan 26, 2016

Changes

  • Adds "Job Title" to the fields supported by Co-Authors Plus
  • Adds the job title to the output of largo_byline if Co-Authors Plus is enabled
  • Adds the job title to the output of largo_byline if Co-Authors Plus is not enabled
  • Does not link the job title to the author's byline page
  • Does not affect largo_author_link
  • Adds the option to show a coauthor's email address. There doesn't appear to be a way to set a default, with how the metabox is constructed, so this will default to hiding the user's email address.
  • Makes partials/author-bio-social-links.php respect the coauthors option. This will only affect coauthors users. This does not affect normal users; their email addresses will still display.

Why

For #1097 and WE-72.

@benlk benlk added this to the 0.5.5 - Story Elements milestone Jan 26, 2016
@benlk benlk modified the milestones: hotfix, 0.5.5 - Story Elements Jan 26, 2016
@benlk benlk added the priority: high Either blocks work on a priority-normal task or a solution here informs other work. label Jan 26, 2016
@benlk
Copy link
Collaborator Author

benlk commented Jan 26, 2016

This is a PR against master, because in discussions on #1097 it was determined that:

  • this was needed for theme-wenews
  • theme-wenews tracks the master branch of largo-dev
  • this PR shouldn't affect other child themes or their websites

…or-bio-description, defaulting to hide.

Affects both normal users and Co-Authors Plus guest authors.
@benlk
Copy link
Collaborator Author

benlk commented Jan 26, 2016

Additional changes (updated after 55a7a7b below):

  • adds site-wide option to show or hide the job title, defaulting to hide
  • adds job title to partials/author-bio-description.php, output as a p.job-title before the description.

A normal user in default Largo:

screen shot 2016-01-26 at 11 25 57 am

A guest author on theme-wenews:

screen shot 2016-01-26 at 11 29 21 am

@benlk
Copy link
Collaborator Author

benlk commented Jan 26, 2016

After merging this, make sure to add these changes to the theme-wenews and theme-invw byline function.

…als/author-bio-description, defaulting to hide."

We decided that this would be better and more-simply done with a site-wide option to disable display of bylines, defaulting to disable

This reverts commit ad85b51.
…s. This matches Adam's suggestion. Also: Move the job title outside the link for coauthors, to match the behavior when Co-Authors Plus is not enabled.
benlk added a commit that referenced this pull request Jan 26, 2016
Add job title to fields accepted by coauthors
@benlk benlk merged commit 69629c2 into master Jan 26, 2016
benlk added a commit that referenced this pull request Jan 26, 2016
@benlk benlk deleted the 1097-coauthors-meta-fields branch February 3, 2016 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants