Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't enqueue unneeded stylesheets for Navis #1113

Open
benlk opened this issue Jan 29, 2016 · 3 comments · May be fixed by #1760
Open

Don't enqueue unneeded stylesheets for Navis #1113

benlk opened this issue Jan 29, 2016 · 3 comments · May be fixed by #1760
Labels
category: performance performance-related issues category: styles affects lots of styles, requiring visual testing Epic Legacy label from Zenhub. Estimate Needed type: bug

Comments

@benlk
Copy link
Collaborator

benlk commented Jan 29, 2016

We're enqueueing the slider and slideshow stylesheets on the search page. We should probably go through Largo's enqueues and make sure that the stylesheets we enqueue on any given page have a possibility of being needed there.
@benlk benlk added this to the 0.6 milestone Jan 29, 2016
@benlk
Copy link
Collaborator Author

benlk commented Jan 29, 2016

Also, the Navis Slideshow plugin enqueues two stylesheets:

@rclations rclations modified the milestones: 0.6 - Performance & SEO, 0.6 Jun 3, 2017
@benlk
Copy link
Collaborator Author

benlk commented Sep 12, 2018

  • change from an outright enqueue to a conditional enqueue that only enqueues them when the slideshow is used on the page.

@benlk benlk mentioned this issue Nov 10, 2018
Closed
@benlk benlk modified the milestones: 0.6.1 - Bugfixes, 0.6.2 Dec 7, 2018
@benlk benlk modified the milestones: 0.6.2, 0.6.3 Dec 19, 2018
@benlk benlk added the Epic Legacy label from Zenhub. label May 16, 2019
@benlk
Copy link
Collaborator Author

benlk commented Jul 12, 2019 •
edited
Loading

@benlk benlk removed this from the 0.6.4 milestone Jul 17, 2019
@benlk benlk linked a pull request Jul 19, 2019 that will close this issue
Open
3 tasks
@benlk benlk added category: performance performance-related issues category: styles affects lots of styles, requiring visual testing labels Aug 21, 2019
This was referenced Aug 21, 2019
Open
Open
@benlk benlk changed the title Don't enqueue unneeded stylesheets Don't enqueue unneeded stylesheets for Navis Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: performance performance-related issues category: styles affects lots of styles, requiring visual testing Epic Legacy label from Zenhub. Estimate Needed type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Conditionally enqueue Navis materials WPBuddy/largo
3 participants
@benlk @rclations @MirandaEcho