Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally enqueue Navis materials #1760

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Conditionally enqueue Navis materials #1760

wants to merge 3 commits into from

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Jul 19, 2019

馃毃 currently broken:

  • galleries on posts

鈿狅笍 unknown:

  • featured media galleries
  • any other places where the gallery styles/js are needed (Gallery widget?)

Changes

  • stops running largo_gallery_enqueue() on every page
  • for all the assets in largo_gallery_enqueue(), enqueue them in the footer

Why

Fixes #1113 by only enqueueing the JS/CSS when it's needed.

To do

  • realize that most of Navis's lightbox code is used on all pages for all images in entry-content
  • see if we can split slideshow from lightbox code
  • better integrate Navis Slideshows plugin into Largo

@benlk benlk added the category: images Issues relating to images label Jul 19, 2019
@benlk benlk changed the base branch from develop to trunk July 19, 2019 23:13
@benlk benlk mentioned this pull request Aug 21, 2019
Open
1 task
@benlk benlk added the category: performance performance-related issues label Aug 21, 2019
@benlk benlk added this to In progress in Largo 0.7 via automation Aug 21, 2019
@benlk benlk added this to To do in 0.7 PR review board Dec 19, 2019
@benlk
Copy link
Collaborator Author

benlk commented Jun 26, 2020

If conditional enqueues aren't working, let's just merge the LESS/CSS with the rest of Largo's styles into one stylesheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: images Issues relating to images category: performance performance-related issues
Projects
0.7 PR review board
  
To do
Largo 0.7
  
In progress
Milestone
0.7 - Foundation for Customization
Development

Successfully merging this pull request may close these issues.

Don't enqueue unneeded stylesheets for Navis
1 participant
@benlk