Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove partials/content-argolinks.php #926

Closed
4 tasks
benlk opened this issue Oct 15, 2015 · 7 comments
Closed
4 tasks

Remove partials/content-argolinks.php #926

benlk opened this issue Oct 15, 2015 · 7 comments
Assignees
Labels
priority: low Nice-to-have in a release. type: improvement

Comments

@benlk
Copy link
Collaborator

benlk commented Oct 15, 2015

As said in #868, argolinks isn't needed anymore, on account of the plugin having become Link Roundups.

@benlk benlk added the priority: low Nice-to-have in a release. label Oct 15, 2015
@benlk benlk changed the title Remove partials/content-argolinks.php? Remove partials/content-argolinks.php Oct 15, 2015
@aschweigert
Copy link

On the 4th point, any references you've seen that we need to review? otherwise let's go ahead with this.

@aschweigert aschweigert modified the milestones: 0.7, 0.6 Oct 16, 2015
@benlk
Copy link
Collaborator Author

benlk commented Oct 16, 2015

Some stuff in the search so it uses the argolinks partial: https://github.com/INN/Largo/blob/master/search.php#L75-L79

And some editor styles that can be removed

@benlk
Copy link
Collaborator Author

benlk commented Dec 15, 2015

When working on this issue, search the whole of the codebase for #926. There are quite a few comments on code that should be removed in this ticket.

@benlk benlk modified the milestones: 0.5.5 - Story Elements, 0.6 Feb 5, 2016
@benlk
Copy link
Collaborator Author

benlk commented Feb 5, 2016

Moving to 0.5.5 for http://jira.inn.org/browse/WE-90

@benlk benlk closed this as completed Feb 5, 2016
@benlk benlk reopened this Feb 5, 2016
@benlk
Copy link
Collaborator Author

benlk commented Feb 5, 2016

Do we not want to do this for 0.5.5?

@aschweigert
Copy link

still todo:

inc/ajax-functions.php:195: // argolinks post type
inc/ajax-functions.php:196: $partial = ( get_post_type() == 'argolinks' ) ? 'argolinks' : $partial;
inc/post-templates.php:288: if ( $post_type == 'argolinks' ) {
inc/post-templates.php:289: $partial = 'argolinks';
tests/inc/test-ajax-functions.php:66: // @todo find way to test get_post_type() returning argolinks.
tests/inc/test-ajax-functions.php:115: // @todo find way to test get_post_type() returning argolinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Nice-to-have in a release. type: improvement
Projects
None yet
Development

No branches or pull requests

2 participants