Support a "None" option for the top term #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds 'none' option to largo_top_tag_display metabox function - changes the validation function for the top term from `intval` to `sanitize_key` because "None" cannot have an id of `'0'` because `'0'` and `0` and `''` are falsy and therefore _largo_meta_box_post_save will remove the option instead of saving it - change largo_top_term so that it outputs `''` if the top term option is `'null'`
benlk
added
the
priority: high
|
Tests wouldn't run on this one on my machine, and I don't know if that's a problem with my vagrant or with our test rig or with this pull request. Please wait for Travis. |
|
Tests ran and passed on Travis, so 👍 See some issues in INN/deploy-tools for why I think tests aren't running on vagrant. |
|
When this merges to develop, merge the |
benlk
added a commit
that referenced
this pull request
Jan 21, 2016
Support a "None" option for the top term
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
intvaltosanitize_keybecause "None" cannot have an id of'0'because'0'and0and''are falsy and therefore _largo_meta_box_post_save will remove the option instead of saving it''if the top term option is'null'Why
For #1082 and RNS-127.