Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1090 fix #1094

Merged
merged 8 commits into from
Jan 25, 2016
Merged

1090 fix #1094

merged 8 commits into from
Jan 25, 2016

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Jan 23, 2016

Changes

  • allows the top term to be a term in the post-type taxonomy
  • change the id for the "None" top term option from string 'null' to string 'none', because it might've been undocumented type conversion.
  • internal documentation of the function largo_top_term
  • rework of the logic of largo_top_term, closing an edge case where a post with the following characteristics would not have a top term link output:
    • category set
    • no top term explicitly set
    • created in the database instead of through the post editor, because that's the only way that such a combo would exist, likely

Why

Because the @!@#$%^&* top term wasn't showing up.

For RNS-104.

@benlk benlk added type: bug priority: high Either blocks work on a priority-normal task or a solution here informs other work. labels Jan 23, 2016
@benlk benlk added this to the 0.5.5 - Story Elements milestone Jan 23, 2016
@benlk
Copy link
Collaborator Author

benlk commented Jan 23, 2016

Please let's write tests for this eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants