Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .travis.yml with wordpress 4.4, 4.3. Remove Wordpress 3.9 and 4.0 #1116

Merged
merged 5 commits into from
Apr 6, 2016

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Feb 3, 2016

Changes

  • Adds 4.4 and 4.3 to .travis.yml
  • Removes the outdated 3.9 and 4.0
  • Updates 4.1 and 4.2 to their latest bugfix versions.

This PR does not fix any tests. it only updates .travis.yml.

Why

Because #1020, and there might be tests failing as a result of changes in versions of WordPress.

@benlk
Copy link
Collaborator Author

benlk commented Apr 4, 2016

  • an error
1) PostTemplatesTestFunctions::test_insert_image_no_thumb
Indirect modification of overloaded property PostTemplatesTestFunctions::$ids has no effect
/tmp/wordpress/src/wp-content/themes/Largo/tests/inc/test-post-templates.php:77
/tmp/wordpress/src/wp-content/themes/Largo/tests/inc/test-post-templates.php:20

@benlk
Copy link
Collaborator Author

benlk commented Apr 5, 2016

There are some tests here that are only failing under PHP 5.5, and some only under PHP 5.3.29, and some that only fail under WordPress 4.4.2 (current stable).

PHP 5.3 is end-of-life (1 year, 7 months ago), but we keep it around because the deploy-tools virtual machines use it (and use a version of Ubuntu 2 years old, without backports), and specifically use PHP 5.3.10. Without special work, the vagrant boxes will never receive PHP 5.3.29.

We don't need to keep PHP 5.3 support.

WP Engine uses PHP 5.5: http://phpinfo.wpengine.com/

They're our primary target.

Upgrading the virtualboxen to Ubuntu 14.04 from their current 12.04 will let us keep the LTS release, but bring PHP 5.5. 16.04 isn't out yet.

@aschweigert
Copy link

do we know what tests are failing?

@benlk
Copy link
Collaborator Author

benlk commented Apr 5, 2016

Two update functions, one related content.

@aschweigert aschweigert merged commit 8311526 into develop Apr 6, 2016
@aschweigert aschweigert deleted the 1020-update-travis-latest-wordpress branch April 6, 2016 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants