Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the custom image sizes options page #1218

Merged
merged 3 commits into from
Sep 12, 2016

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented May 6, 2016

Changes

  • deregisters the Wordpress /wp-admin/options-media.php page from menus.

Why

As described in #404, Largo forces these image sizes so it doesn't make sense to have the admin page settings visible and inoperable.

…sizes so it doesn't make sense to have the admin page
@benlk benlk added the priority: normal Must be completed before release of this version of plugin. label May 6, 2016
@benlk benlk added this to the 0.5.5 - Story Elements milestone May 6, 2016
@aschweigert
Copy link

@benlk same here, this is fine, just needs to get back up to date with develop so we can merge it

@benlk
Copy link
Collaborator Author

benlk commented Sep 3, 2016

Waiting on Travis, but I don't think there are any unexpected errors in the tests.

@aschweigert aschweigert merged commit ddf5efe into develop Sep 12, 2016
@aschweigert aschweigert deleted the 404-hide-media-options.php branch September 21, 2016 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. status: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants