Add a case for the generic post_type in archive.php #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d url in archive.php
…t of their domain
|
In the case of Roundups given by the Link Roundups plugin, this does respect the |
| @@ -53,7 +53,10 @@ | |||
| * @since 0.5.4 | |||
| */ | |||
| $title = apply_filters( 'largo_archive_rounduplink_title', __( 'Saved Links' , 'largo' ) ); | |||
There was a problem hiding this comment.
Collapse these two is_post_type_archive sections into one that runs the filter 'largo_archive_' . $post_type . '_title', and add a similar filter for the default feed url.
The largo_archive_rounduplink_title filter is replaced with a generic
largo_archive_{$post_type}_title filter, maintaining compatibility with
existing filters.
The largo_archive_{$post_type}_feed filter is new, and allows filtering the feed
URL. The feed URL here is no longer specific to the rounduplink post type, instead takes
the form /feed/?post_type=post_type
Also updates the hooks-and-filters docs
|
Updated: Changes
WhyFor #1231, makes sure there's a title for all Switches to generics to make sure that everything can be filtered. Adds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
elseif ( is_post_type_archive() ) {to the section at the start of the file:post_type_archive_title()'/feed/?post_type=' . urlencode($wp_query->query_vars['post_type']), which will look likehttp://example.com/feed/?post_type=roundupsite_url(), to make them point to the correct URL if the site is not hosted at the root of its domain.Why
For #1231, makes sure there's a title for all
post_typearchives.Adds site_url because it's a better practice than to rely on
/being the root of the site.