Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making Post Prominence tax items created via wp-admin visible on post add/edit screens #1255

Merged

Conversation

rclations
Copy link

This PR is an update of #1252, but applied against the master branch as a hotfix

Fixes issue identified in #956

Prominence Terms added via /wp-admin/edit-tags.php?taxonomy=prominence are not displayed in the add/edit post screens.

This appears to be caused by the for loop that creates $termList in https://github.com/INN/Largo/blob/master/inc/post-metaboxes.php#L314

$largoProminenceTerms and by extension, $slugs only pull the default options set in the theme at https://github.com/INN/Largo/blob/master/inc/taxonomies.php#L90, so the for loop is only adding items to the display which exist in the default theme set.

I'm not sure if this loop was intended for something else, but removing it entirely and renaming $terms to $termList fixes the issue.

@benlk
Copy link
Collaborator

benlk commented Jul 18, 2016

The failing test here is test_largo_fb_user_is_followable, which is known and was fixed with develop in #1234.

@benlk benlk added this to the hotfix milestone Jul 18, 2016
@benlk benlk added type: bug priority: normal Must be completed before release of this version of plugin. status: in progress status: needs review labels Jul 18, 2016
@aschweigert aschweigert merged commit 955f744 into WPBuddy:master Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. status: in progress type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants