Display sticky header on all pages #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sn't controlling the behavior as expected.
How this works: If the sticky nav is set to be displayed, then the option gets added as a class by js/navigation.js lines 82-85.
benlk
added
priority: normal
|
Ben:
Adam:
|
| @@ -79,6 +79,7 @@ | |||
| Navigation.prototype.bindStickyNavEvents = function() { | |||
| var self = this; | |||
|
|
|||
| // This is so that we may | |||
…ked in last time it was recompiled
|
Failed tests are the usual; merging |
benlk
added a commit
to INN/umbrella-rivard-report
that referenced
this pull request
Aug 3, 2016
This was referenced Aug 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
sticky_nav_display_articleoption tosticky_nav_display_allsticky_nav_display_allnow controls whether or not the sticky nave displays on all pages on the site or on no pages. If it is checked (by default it is), then sticky navs will appear after scrolling past the main nav.sticky_nav_display_allchanges from "Enable the sticky navigation for all screen sizes on article pages" to "Enable the sticky navigation for all screen sizes"less/inc/navbar_sticky.lessto allow the navbar to display on all page types, while still being controlled by the checkboxThe sticky nav's appearance behavior is unchanged: it only appears when scrolling upwards, or when the screen width is less than 769px. (for that width, see #1261)
The functionality of the
main_nav_hide_article"Hide the main navigation on article pages and display only the sticky navigation on article pages" checkbox is unchanged.Questions
sticky_nav_display_articleto something else, to reflect that that theme option now controls whether or not the sticky nav displays on all pages?
## WhyFor #1260.