Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent sticky hav container from having height set before the nav is set to display #1269

Merged
merged 3 commits into from
Aug 17, 2016

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Aug 16, 2016

Changes

  • When the sticky nav is set to display on the homepage, the height of the container element shall be nothing.
  • Merge the cases for "It's a phone" and "We're hiding the main nav on an article and only displaying the sticky nav" because they're doing the same things.
    • but continue running this.stickyNavScrollTopHide() on the "Always show sticky navs" case

Noticed bug:

…tion.prototype.stickyNavResizeCallback since they were doing the same thing, and remove comments
@aschweigert
Copy link

that seems reasonable to me

@benlk benlk merged commit 425de70 into develop Aug 17, 2016
benlk added a commit that referenced this pull request Aug 17, 2016
@aschweigert aschweigert deleted the 1260-set-no-height-on-hidden-nav branch September 21, 2016 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants