Fix for "Page not found" on categories with hierarchical header and < 5 posts #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader, it does not display the not-found template if there are no posts in the main Loop.
|
looks good to me - do we want to merge this into master or develop? |
|
this can go directly to master as a hotfix |
|
The failing test on this PR is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
partials/content-not-found.phpif there are n < 6 posts in the category and the featured header is displayed.Page Not Foundif it's not a 404. Examples of where this situation may occur:index.phparchive.phpandcategory.phpif no posts match the querypartials/home-post-list.phpUsing the same site as the original screenshot in #898 for these screenshots.
This is why the changes to
partials/content-not-found.php:After those changes:
A 404 in this PR; nothing's changed: