Do better detection of no related topics in Largo's category template #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks great to me |
|
No umbrella site duplicates this partial, so it's ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
largo_get_related_topics_for_category()now outputs empty string if there are no related topicspartials/archive-category-related.phpis changed to matchlargo_get_related_topics_for_category().Why
Changes in
largo_get_related_topics_for_categoryfor #1288:<ul></ul>because if we wanted to keep detecting the HTML elements in the partial,partials/archive-category-related.phpwould have to match the output of that function to the output ofapply_filters( 'largo_related_topics_title_ul', __( 'Related Topics:' , 'largo' ) );, wrapped in aul li strong.Spaces to tabs to align this with the WordPress PHP code standards.